Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 15540004: Auto-generate HTMLFrameSetElement::namedPropertyGetter (Closed)

Created:
7 years, 7 months ago by kojih
Modified:
7 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, adamk+blink_chromium.org, haraken, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Auto-generate HTMLFrameSetElement::namedPropertyGetter Removed V8HTMLFrameSetElementCustom.cpp. Also fix a bug: do 2 necessary checks - GetRealNamedPropertyInPrototypeChain - HasRealNamedCallbackProperty No tests: It's hard to add a test case for it. see https://codereview.chromium.org/15373004/ R=haraken@chromium.org BUG=229740 TEST=No tests.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -71 lines) Patch
M Source/bindings/bindings.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/CodeGeneratorV8.pm View 3 chunks +1 line, -6 lines 3 comments Download
D Source/bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 2 chunks +13 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.idl View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3 (0 generated)
kojih
r? Diff of generated code: +v8::Handle<v8::Value> V8HTMLFrameSetElement::namedPropertyGetter(v8::Local<v8::String> name, const v8::AccessorInfo& info) +{ + if (!info.Holder()->GetRealNamedPropertyInPrototypeChain(name).IsEmpty()) ...
7 years, 7 months ago (2013-05-21 07:35:12 UTC) #1
haraken
Almost looks good to me, but the new code introduces a GetRealNamedPropertyInPrototypeChain() check and a ...
7 years, 7 months ago (2013-05-21 14:06:41 UTC) #2
kojih
7 years, 7 months ago (2013-05-22 09:33:05 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698