Issue 15517007: Change InstantAutocompleteResult::Type to be AutocompleteMatchType::Type.

Issue 15517007: Change InstantAutocompleteResult::Type to be AutocompleteMatchType::Type. (Closed)

Created:
7 years, 7 months ago by kmadhusu

Modified:
7 years, 7 months ago

Reviewers:
palmer, samarth, kmadhusu

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, sreeram, gideonwald, dominich, Aaron Boodman, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, chromium-apps-reviews_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change InstantAutocompleteResult::Type to be AutocompleteMatchType::Type. To pass InstantAutocompleteResult::Type back and forth between the browser and renderer, change the data type to be AutocompleteMatchType::Type instead of an opaque string. BUG=239173 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202017

Patch Set 1 : '' #

Total comments: 2

Patch Set 2 : Addressed comment. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
M	chrome/browser/ui/search/instant_controller.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search/instant_extended_interactive_uitest.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/common/instant_types.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/common/render_messages.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/renderer/searchbox/searchbox_extension.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

samarth

lgtm https://codereview.chromium.org/15517007/diff/5001/chrome/browser/ui/search/instant_controller.cc File chrome/browser/ui/search/instant_controller.cc (right): https://codereview.chromium.org/15517007/diff/5001/chrome/browser/ui/search/instant_controller.cc#newcode1836 chrome/browser/ui/search/instant_controller.cc:1836: DVLOG(1) << " " << result->relevance << " ...

7 years, 7 months ago (2013-05-23 21:09:38 UTC) #2

kmadhusu

palmer: Please review chrome/common/render_messages.h Thanks. https://codereview.chromium.org/15517007/diff/5001/chrome/browser/ui/search/instant_controller.cc File chrome/browser/ui/search/instant_controller.cc (right): https://codereview.chromium.org/15517007/diff/5001/chrome/browser/ui/search/instant_controller.cc#newcode1836 chrome/browser/ui/search/instant_controller.cc:1836: DVLOG(1) << " " ...

7 years, 7 months ago (2013-05-23 21:53:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/15517007/13001

7 years, 7 months ago (2013-05-23 22:05:05 UTC) #5

Message was sent while issue was closed.

Change committed as 202017

Expand Messages | Collapse Messages