Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: chrome/browser/ui/search/instant_controller.cc

Issue 15517007: Change InstantAutocompleteResult::Type to be AutocompleteMatchType::Type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comment. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/search/instant_controller.h" 5 #include "chrome/browser/ui/search/instant_controller.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 8
9 #include "base/metrics/histogram.h" 9 #include "base/metrics/histogram.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
(...skipping 1805 matching lines...) Expand 10 before | Expand all | Expand 10 after
1816 // TODO(dcblack): Remove extraneous history entry caused by 404s. 1816 // TODO(dcblack): Remove extraneous history entry caused by 404s.
1817 // Note that the base case of a 204 being returned doesn't push a history 1817 // Note that the base case of a 204 being returned doesn't push a history
1818 // entry. 1818 // entry.
1819 } 1819 }
1820 1820
1821 void InstantController::PopulateInstantAutocompleteResultFromMatch( 1821 void InstantController::PopulateInstantAutocompleteResultFromMatch(
1822 const AutocompleteMatch& match, size_t autocomplete_match_index, 1822 const AutocompleteMatch& match, size_t autocomplete_match_index,
1823 InstantAutocompleteResult* result) { 1823 InstantAutocompleteResult* result) {
1824 DCHECK(result); 1824 DCHECK(result);
1825 result->provider = UTF8ToUTF16(match.provider->GetName()); 1825 result->provider = UTF8ToUTF16(match.provider->GetName());
1826 result->type = UTF8ToUTF16(AutocompleteMatchType::ToString(match.type)); 1826 result->type = match.type;
1827 result->description = match.description; 1827 result->description = match.description;
1828 result->destination_url = UTF8ToUTF16(match.destination_url.spec()); 1828 result->destination_url = UTF8ToUTF16(match.destination_url.spec());
1829 1829
1830 // Setting the search_query field tells the Instant page to treat the 1830 // Setting the search_query field tells the Instant page to treat the
1831 // suggestion as a query. 1831 // suggestion as a query.
1832 if (AutocompleteMatch::IsSearchType(match.type)) 1832 if (AutocompleteMatch::IsSearchType(match.type))
1833 result->search_query = match.contents; 1833 result->search_query = match.contents;
1834 1834
1835 result->transition = match.transition; 1835 result->transition = match.transition;
1836 result->relevance = match.relevance; 1836 result->relevance = match.relevance;
1837 result->autocomplete_match_index = autocomplete_match_index; 1837 result->autocomplete_match_index = autocomplete_match_index;
1838 1838
1839 DVLOG(1) << " " << result->relevance << " " << result->type << " " 1839 DVLOG(1) << " " << result->relevance << " "
1840 << UTF8ToUTF16(AutocompleteMatchType::ToString(result->type)) << " "
1840 << result->provider << " " << result->destination_url << " '" 1841 << result->provider << " " << result->destination_url << " '"
1841 << result->description << "' '" << result->search_query << "' " 1842 << result->description << "' '" << result->search_query << "' "
1842 << result->transition << " " << result->autocomplete_match_index; 1843 << result->transition << " " << result->autocomplete_match_index;
1843 } 1844 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698