Use prod logger's user context to read logging level

Use prod logger's user context to read logging level

TBR=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org
BUG=https://github.com/luci/gae/issues/32

Committed: https://github.com/luci/gae/commit/eac0014ebc7f0a9cf7fa45c5a823e22237673e30

[iannucci, 2015-12-23 16:34:43]

https://chromiumcodereview.appspot.com/1542263003/diff/1/impl/prod/logger.go
File impl/prod/logger.go (right):

https://chromiumcodereview.appspot.com/1542263003/diff/1/impl/prod/logger.go#...
impl/prod/logger.go:43: if gl.aeCtx == nil || !logging.IsLogging(gl.ic, l) {
If you look below (line 62), we use the ic context to pull fields for logging.
When the logging lib changes the level, it's changing it on ic, not aeCtx.

[iannucci, 2015-12-23 16:35:00]

(I think this change is pretty obviously correct, so TBR'ing)

[iannucci, 2015-12-23 16:35:03]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2015-12-23 16:35:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1542263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1542263003/1

[commit-bot: I haz the power, 2015-12-23 16:36:38]

Description was changed from

==========
Use prod logger's user context to read logging level

TBR=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=https://github.com/luci/gae/issues/32
==========

to

==========
Use prod logger's user context to read logging level

TBR=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=https://github.com/luci/gae/issues/32

Committed:
https://github.com/luci/gae/commit/eac0014ebc7f0a9cf7fa45c5a823e22237673e30
==========

[commit-bot: I haz the power, 2015-12-23 16:36:39]

Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/eac0014ebc7f0a9cf7fa45c5a823e22237673e30

[estaab, 2015-12-23 16:50:46]

lgtm

https://codereview.chromium.org/1542263003/diff/1/impl/prod/logger.go
File impl/prod/logger.go (right):

https://codereview.chromium.org/1542263003/diff/1/impl/prod/logger.go#newcode25
impl/prod/logger.go:25: ic    context.Context
what does the i in ic stand for?

[iannucci, 2015-12-23 20:07:13]

inner, though honestly it should just shadow 'c'. Lots of functions do this
right now so it's at least consistent. Worth a cleanup CL.

On Wed, Dec 23, 2015, 08:50  <estaab@chromium.org> wrote:

> lgtm
>
>
>
>
> https://codereview.chromium.org/1542263003/diff/1/impl/prod/logger.go
> File impl/prod/logger.go (right):
>
>
>
https://codereview.chromium.org/1542263003/diff/1/impl/prod/logger.go#newcode25
> impl/prod/logger.go:25
>
<https://codereview.chromium.org/1542263003/diff/1/impl/prod/logger.go#newcode...>:
> ic    context.Context
> what does the i in ic stand for?
>
> https://codereview.chromium.org/1542263003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dnj, 2015-12-24 16:42:43]

lgtm