Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1541183002: Make setting a Memcache Item with a nil Value OK (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Make setting a Memcache Item with a nil Value OK This conforms to the expectations that if you Set with a nil Value, it's the same as setting to []byte{}... One less trap :) R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/31 Committed: https://github.com/luci/gae/commit/8453e7a9d7b9e02690b34b5cd141cf3e46a0a933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M impl/memory/memcache_test.go View 1 chunk +8 lines, -0 lines 0 comments Download
M impl/prod/everything_test.go View 3 chunks +10 lines, -0 lines 0 comments Download
M impl/prod/memcache.go View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
iannucci
5 years ago (2015-12-22 17:11:12 UTC) #1
martiniss
lgtm
5 years ago (2015-12-22 18:37:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1541183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1541183002/1
5 years ago (2015-12-23 16:25:38 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-23 16:28:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/8453e7a9d7b9e02690b34b5cd141cf3e46a0a933

Powered by Google App Engine
This is Rietveld 408576698