Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 15403002: Remving global statics from the headers, so we can split-link. (Closed)

Created:
7 years, 7 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 7 months ago
Reviewers:
scottmg
CC:
chromium-reviews, MAD, jar (doing other things), jam, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remving global statics from the headers, so we can split-link. The issue is that the split linker has issues with data exports vs function exports currently only function exports are supported. NOTRY=true TBR=brettw,jam TEST=none BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201194

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixing unittests #

Patch Set 3 : adding export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -42 lines) Patch
M base/logging.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M base/logging.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M base/logging_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/metrics/stats_table.h View 2 chunks +2 lines, -4 lines 0 comments Download
M base/metrics/stats_table.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M content/common/child_process.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/common/child_process.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M ppapi/shared_impl/ppapi_globals.h View 2 chunks +1 line, -9 lines 0 comments Download
M ppapi/shared_impl/ppapi_globals.cc View 1 chunk +16 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
lgtm when everything's green https://codereview.chromium.org/15403002/diff/1/base/logging.h File base/logging.h (right): https://codereview.chromium.org/15403002/diff/1/base/logging.h#newcode651 base/logging.h:651: DcheckState get_dcheck_state(); seems like a ...
7 years, 7 months ago (2013-05-20 19:15:15 UTC) #1
cpu_(ooo_6.6-7.5)
yes, done.
7 years, 7 months ago (2013-05-20 20:56:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/15403002/12001
7 years, 7 months ago (2013-05-21 01:27:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=3861
7 years, 7 months ago (2013-05-21 01:33:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/15403002/12001
7 years, 7 months ago (2013-05-21 01:41:20 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 01:42:12 UTC) #6
Message was sent while issue was closed.
Change committed as 201194

Powered by Google App Engine
This is Rietveld 408576698