Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: base/logging.h

Issue 15403002: Remving global statics from the headers, so we can split-link. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: adding export Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/logging.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.h
diff --git a/base/logging.h b/base/logging.h
index 71596f09cecef6490c85abead623c192a1d718af..55c9ebfafbf3db7f44419145bcb486073fff6e88 100644
--- a/base/logging.h
+++ b/base/logging.h
@@ -648,7 +648,8 @@ enum { DEBUG_MODE = ENABLE_DLOG };
#if defined(NDEBUG)
-BASE_EXPORT extern DcheckState g_dcheck_state;
+BASE_EXPORT DcheckState get_dcheck_state();
+BASE_EXPORT void set_dcheck_state(DcheckState state);
#if defined(DCHECK_ALWAYS_ON)
@@ -665,7 +666,7 @@ const LogSeverity LOG_DCHECK = LOG_FATAL;
#define COMPACT_GOOGLE_LOG_DCHECK COMPACT_GOOGLE_LOG_ERROR_REPORT
const LogSeverity LOG_DCHECK = LOG_ERROR_REPORT;
#define DCHECK_IS_ON() \
- ((::logging::g_dcheck_state == \
+ ((::logging::get_dcheck_state() == \
::logging::ENABLE_DCHECK_FOR_NON_OFFICIAL_RELEASE_BUILDS) && \
LOG_IS_ON(DCHECK))
« no previous file with comments | « no previous file | base/logging.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698