Force at least first and last name for CREDIT_CARD_NAME when using Wallet.

Force at least first and last name for CREDIT_CARD_NAME when using Wallet.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202618

[ahutter, 2013-05-21 21:09:26]

Evan, PTAL. Thanks.

[ahutter, 2013-05-23 15:36:19]

Friendly ping.

[Evan Stade, 2013-05-23 16:40:37]

https://codereview.chromium.org/15401005/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/15401005/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:250:
base::string16 whitespace_collapsed_name = CollapseWhitespace(trimmed_name,
collapsewhitespace trims (so I don't think you need to also call TrimWhitespace)

https://codereview.chromium.org/15401005/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1134:
ASCIIToUTF16("Google Wallet requires a first and last name");
i10n

[ahutter, 2013-05-23 23:19:11]

https://codereview.chromium.org/15401005/diff/1/chrome/browser/ui/autofill/au...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/15401005/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:250:
base::string16 whitespace_collapsed_name = CollapseWhitespace(trimmed_name,
On 2013/05/23 16:40:37, Evan Stade wrote:
> collapsewhitespace trims (so I don't think you need to also call
TrimWhitespace)

Done.

https://codereview.chromium.org/15401005/diff/1/chrome/browser/ui/autofill/au...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1134:
ASCIIToUTF16("Google Wallet requires a first and last name");
On 2013/05/23 16:40:37, Evan Stade wrote:
> i10n

Done.

[Evan Stade, 2013-05-23 23:28:40]

https://codereview.chromium.org/15401005/diff/6001/chrome/browser/ui/autofill...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/15401005/diff/6001/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1124: if
(field_values.count(CREDIT_CARD_NAME)) {
can you put this in InputValidityMessage()? InputsAreValid should handle checks
that only depend on a single field. InputsAreValid handles checks that depend on
multiple fields.

p.s. perhaps InputValidityMessage is not as good a name as SingleInputIsValid or
something, and that's why this distinction was unclear.

[ahutter, 2013-05-24 18:36:02]

Moved the check. PTAL. Thanks.

https://codereview.chromium.org/15401005/diff/6001/chrome/browser/ui/autofill...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/15401005/diff/6001/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1124: if
(field_values.count(CREDIT_CARD_NAME)) {
On 2013/05/23 23:28:40, Evan Stade wrote:
> can you put this in InputValidityMessage()? InputsAreValid should handle
checks
> that only depend on a single field. InputsAreValid handles checks that depend
on
> multiple fields.
> 
> p.s. perhaps InputValidityMessage is not as good a name as SingleInputIsValid
or
> something, and that's why this distinction was unclear.

Done.

[Evan Stade, 2013-05-24 19:22:53]

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1140: if
(value.empty())
how about:

if (!value.empty() && !IsValidEmailAddress(value))
  return "Are you sure?";
break;

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1144:
ASCIIToUTF16("Are you sure this is right?");
\n

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1151:
ASCIIToUTF16("Are you sure this is right?");
\n

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1155: return
l10n_util::GetStringUTF16(
too much indent

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1158: break;
\n

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1161: break;
\n

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1167:
ASCIIToUTF16("Are you sure this is right?");
\n

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1170: break;
\n

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1172: return
base::string16();  // Line 2 is optional - always valid.
\n

[ahutter, 2013-05-24 19:55:43]

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1140: if
(value.empty())
On 2013/05/24 19:22:54, Evan Stade wrote:
> how about:
> 
> if (!value.empty() && !IsValidEmailAddress(value))
>   return "Are you sure?";
> break;

Done.

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1144:
ASCIIToUTF16("Are you sure this is right?");
On 2013/05/24 19:22:54, Evan Stade wrote:
> \n

two newlines?

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1151:
ASCIIToUTF16("Are you sure this is right?");
On 2013/05/24 19:22:54, Evan Stade wrote:
> \n

Done.

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1155: return
l10n_util::GetStringUTF16(
On 2013/05/24 19:22:54, Evan Stade wrote:
> too much indent

Done.

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1158: break;
On 2013/05/24 19:22:54, Evan Stade wrote:
> \n

Done.

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1161: break;
On 2013/05/24 19:22:54, Evan Stade wrote:
> \n

Done.

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1167:
ASCIIToUTF16("Are you sure this is right?");
On 2013/05/24 19:22:54, Evan Stade wrote:
> \n

two newlines?

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1170: break;
On 2013/05/24 19:22:54, Evan Stade wrote:
> \n

Done.

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1172: return
base::string16();  // Line 2 is optional - always valid.
On 2013/05/24 19:22:54, Evan Stade wrote:
> \n

Done.

[Evan Stade, 2013-05-24 21:29:35]

lgtm

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1144:
ASCIIToUTF16("Are you sure this is right?");
On 2013/05/24 19:55:43, ahutter wrote:
> On 2013/05/24 19:22:54, Evan Stade wrote:
> > \n
> 
> two newlines?

ah, no.

https://codereview.chromium.org/15401005/diff/13001/chrome/browser/ui/autofil...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1167:
ASCIIToUTF16("Are you sure this is right?");
On 2013/05/24 19:55:43, ahutter wrote:
> On 2013/05/24 19:22:54, Evan Stade wrote:
> > \n
> 
> two newlines?

ah, no.

[commit-bot: I haz the power, 2013-05-24 23:01:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ahutter@chromium.org/15401005/18001

[commit-bot: I haz the power, 2013-05-25 00:52:32]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win7_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-28 16:19:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ahutter@chromium.org/15401005/41001

[commit-bot: I haz the power, 2013-05-28 19:06:51]

Change committed as 202618