Force at least first and last name for CREDIT_CARD_NAME when using Wallet.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/base64.h"
@@ skipping 292 matching lines @@
     if (type != ADDRESS_HOME_LINE2 &&
         type != CREDIT_CARD_VERIFICATION_CODE &&
         data_model.GetInfo(type, app_locale).empty()) {
       return false;
     }
   }
 
   return true;
 }
 
+bool IsCardHolderNameValidForWallet(const string16& name) {
+  base::string16 whitespace_collapsed_name = CollapseWhitespace(name, true);
+  std::vector<base::string16> split_name;
+  base::SplitString(whitespace_collapsed_name, ' ', &split_name);
+  return split_name.size() >= 2;
+}
+
 }  // namespace
 
 AutofillDialogController::~AutofillDialogController() {}
 
 AutofillDialogControllerImpl::~AutofillDialogControllerImpl() {
   if (popup_controller_)
     popup_controller_->Hide();
 
   GetMetricLogger().LogDialogInitialUserState(
       GetDialogType(), initial_user_state_);
@@ skipping 798 matching lines @@
   }
 
   return gfx::Image();
 }
 
 // TODO(estade): Replace all the error messages here with more helpful and
 // translateable ones. TODO(groby): Also add tests.
 string16 AutofillDialogControllerImpl::InputValidityMessage(
     AutofillFieldType type,
     const string16& value) const {
-  if (InputIsValid(type, value))
-    return string16();
+  switch (AutofillType::GetEquivalentFieldType(type)) {
+    case EMAIL_ADDRESS:
+      if (!value.empty() && !IsValidEmailAddress(value))
+        return ASCIIToUTF16("Are you sure this is right?");
+      break;
 
-  if (value.empty())
-    return ASCIIToUTF16("You forgot one");
+    case CREDIT_CARD_NUMBER:
+      if (!value.empty() && !autofill::IsValidCreditCardNumber(value))
+        return ASCIIToUTF16("Are you sure this is right?");
+      break;
 
-  return ASCIIToUTF16("Are you sure this is right?");
+    case CREDIT_CARD_NAME:
+      // Wallet requires a first and last name.
+      if (!value.empty() && IsPayingWithWallet() &&
+          !IsCardHolderNameValidForWallet(value)) {
+        return l10n_util::GetStringUTF16(
+            IDS_AUTOFILL_DIALOG_VALIDATION_WALLET_REQUIRES_TWO_NAMES);
+      }
+      break;
+
+    case CREDIT_CARD_EXP_MONTH:
+    case CREDIT_CARD_EXP_4_DIGIT_YEAR:
+      break;
+
+    case CREDIT_CARD_VERIFICATION_CODE:
+      if (!value.empty() && !autofill::IsValidCreditCardSecurityCode(value))
+          return ASCIIToUTF16("Are you sure this is right?");
+      break;
+
+    case ADDRESS_HOME_LINE1:
+      break;
+
+    case ADDRESS_HOME_LINE2:
+      return base::string16();  // Line 2 is optional - always valid.
+
+    case ADDRESS_HOME_CITY:
+    case ADDRESS_HOME_STATE:
+    case ADDRESS_HOME_ZIP:
+    case ADDRESS_HOME_COUNTRY:
+      break;
+
+    case NAME_FULL:  // Used for shipping.
+      break;
+
+    case PHONE_HOME_WHOLE_NUMBER:  // Used in billing section.
+      break;
+
+    default:
+      NOTREACHED();  // Trying to validate unknown field.
+      break;
+  }
+
+  return !value.empty() ? base::string16() : ASCIIToUTF16("You forgot one");
 }
 
 // TODO(estade): Replace all the error messages here with more helpful and
 // translateable ones. TODO(groby): Also add tests.
 ValidityData AutofillDialogControllerImpl::InputsAreValid(
     const DetailOutputMap& inputs, ValidationType validation_type) const {
   ValidityData invalid_messages;
   std::map<AutofillFieldType, string16> field_values;
   for (DetailOutputMap::const_iterator iter = inputs.begin();
        iter != inputs.end(); ++iter) {
@@ skipping 20 matching lines @@
       invalid_messages[CREDIT_CARD_EXP_MONTH] =
           ASCIIToUTF16("more complicated message");
       invalid_messages[CREDIT_CARD_EXP_4_DIGIT_YEAR] =
           ASCIIToUTF16("more complicated message");
     }
   }
 
   // If there is a credit card number and a CVC, validate them together.
   if (field_values.count(CREDIT_CARD_NUMBER) &&
       field_values.count(CREDIT_CARD_VERIFICATION_CODE) &&
-      InputIsValid(CREDIT_CARD_NUMBER, field_values[CREDIT_CARD_NUMBER])) {
+      InputValidityMessage(CREDIT_CARD_NUMBER,
+                           field_values[CREDIT_CARD_NUMBER]).empty()) {
     if (!autofill::IsValidCreditCardSecurityCode(
             field_values[CREDIT_CARD_VERIFICATION_CODE],
             field_values[CREDIT_CARD_NUMBER])) {
       invalid_messages[CREDIT_CARD_VERIFICATION_CODE] =
           ASCIIToUTF16("CVC doesn't match card type!");
     }
   }
 
   // Validate the phone number against the country code of the address.
   if (field_values.count(ADDRESS_HOME_COUNTRY) &&
@@ skipping 1065 matching lines @@
 }
 
 bool AutofillDialogControllerImpl::IsManuallyEditingAnySection() const {
   for (size_t section = SECTION_MIN; section <= SECTION_MAX; ++section) {
     if (IsManuallyEditingSection(static_cast<DialogSection>(section)))
       return true;
   }
   return false;
 }
 
-bool AutofillDialogControllerImpl::InputIsValid(AutofillFieldType type,
-                                                const string16& value) const {
-  switch (AutofillType::GetEquivalentFieldType(type)) {
-    case EMAIL_ADDRESS:
-      return IsValidEmailAddress(value);
-
-    case CREDIT_CARD_NUMBER:
-      return autofill::IsValidCreditCardNumber(value);
-    case CREDIT_CARD_NAME:
-      break;
-    case CREDIT_CARD_EXP_MONTH:
-    case CREDIT_CARD_EXP_4_DIGIT_YEAR:
-      break;
-    case CREDIT_CARD_VERIFICATION_CODE:
-      return autofill::IsValidCreditCardSecurityCode(value);
-
-    case ADDRESS_HOME_LINE1:
-      break;
-    case ADDRESS_HOME_LINE2:
-      return true;  // Line 2 is optional - always valid.
-    case ADDRESS_HOME_CITY:
-    case ADDRESS_HOME_STATE:
-    case ADDRESS_HOME_ZIP:
-    case ADDRESS_HOME_COUNTRY:
-      break;
-
-    case NAME_FULL:  // Used for shipping.
-      break;
-
-    case PHONE_HOME_WHOLE_NUMBER:  // Used in billing section.
-      break;
-
-    default:
-      NOTREACHED();  // Trying to validate unknown field.
-      break;
-  }
-
-  return !value.empty();
-}
-
 bool AutofillDialogControllerImpl::AllSectionsAreValid() const {
   for (size_t section = SECTION_MIN; section <= SECTION_MAX; ++section) {
     if (!SectionIsValid(static_cast<DialogSection>(section)))
       return false;
   }
   return true;
 }
 
 bool AutofillDialogControllerImpl::SectionIsValid(
     DialogSection section) const {
@@ skipping 463 matching lines @@
         AutofillMetrics::DIALOG_USER_SIGNED_IN_NO_WALLET_NO_AUTOFILL;
   }
 
   // Has Wallet items.
   return has_autofill_profiles ?
       AutofillMetrics::DIALOG_USER_SIGNED_IN_HAS_WALLET_HAS_AUTOFILL :
       AutofillMetrics::DIALOG_USER_SIGNED_IN_HAS_WALLET_NO_AUTOFILL;
 }
 
 }  // namespace autofill