Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1539883002:
iSAC: Remove unnecessary WEBRTC_LINUX define. (Closed)
|
Created:
5 years ago by kjellander_webrtc Modified:
5 years ago Reviewers:
tlegrand-webrtc CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptioniSAC: Remove unnecessary WEBRTC_LINUX define.
I can only find one use in iSAC codebase:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc/modules/audio_coding/test/iSACTest.cc&l=19
It's the prime suspect for causing a compilation error for iOS failing to
include linux/net.h which is being included in
webrtc/voice_engine/voice_engine_defines.h
NOTRY=True
Committed: https://crrev.com/740c367af39845dd79e190d57cfe9f6faa8ae3e5
Cr-Commit-Position: refs/heads/master@{#11089}
Patch Set 1 #
Messages
Total messages: 14 (6 generated)
Description was changed from ========== iSAC: Remove unnecessary WEBRTC_LINUX define. It isn't used anywhere in the iSAC codebase. It's the prime suspect for causing a compilation error for iOS failing to include linux/net.h which is being included in webrtc/voice_engine/voice_engine_defines.h ========== to ========== iSAC: Remove unnecessary WEBRTC_LINUX define. I can only find one use in iSAC codebase: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... It's the prime suspect for causing a compilation error for iOS failing to include linux/net.h which is being included in webrtc/voice_engine/voice_engine_defines.h ==========
kjellander@webrtc.org changed reviewers: + tina.legrand@webrtc.org
(ignore the iOS GN bots, they're failing because GN is not yet building on iOS, I triggered them by mistake)
Description was changed from ========== iSAC: Remove unnecessary WEBRTC_LINUX define. I can only find one use in iSAC codebase: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... It's the prime suspect for causing a compilation error for iOS failing to include linux/net.h which is being included in webrtc/voice_engine/voice_engine_defines.h ========== to ========== iSAC: Remove unnecessary WEBRTC_LINUX define. I can only find one use in iSAC codebase: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... It's the prime suspect for causing a compilation error for iOS failing to include linux/net.h which is being included in webrtc/voice_engine/voice_engine_defines.h NOTRY=True ==========
On 2015/12/18 11:47:57, kjellander (webrtc) wrote: > (ignore the iOS GN bots, they're failing because GN is not yet building on iOS, > I triggered them by mistake) Please, make sure you trigger trybots which actually run audio_decoders_unittest and modules_unittests, and where this change affects the build (i.e., non-win and non-linux).
On 2015/12/18 12:55:28, hlundin-webrtc wrote: > On 2015/12/18 11:47:57, kjellander (webrtc) wrote: > > (ignore the iOS GN bots, they're failing because GN is not yet building on > iOS, > > I triggered them by mistake) > > Please, make sure you trigger trybots which actually run audio_decoders_unittest > and modules_unittests, and where this change affects the build (i.e., non-win > and non-linux). I triggered mac_rel, mac_dbg, android_rel and android_dbg. Let's wait for them to go green, and then LGTM.
On 2015/12/18 13:02:16, tlegrand-webrtc wrote: > On 2015/12/18 12:55:28, hlundin-webrtc wrote: > > On 2015/12/18 11:47:57, kjellander (webrtc) wrote: > > > (ignore the iOS GN bots, they're failing because GN is not yet building on > > iOS, > > > I triggered them by mistake) > > > > Please, make sure you trigger trybots which actually run > audio_decoders_unittest > > and modules_unittests, and where this change affects the build (i.e., non-win > > and non-linux). > > I triggered mac_rel, mac_dbg, android_rel and android_dbg. Let's wait for them > to go green, and then LGTM. I tracked it down using git blame and it was added when the initial isacfix.gyp was created, so there's no trace of the reason for adding it in the first place. Since all tests passed, I'm going to commit this.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539883002/1
Message was sent while issue was closed.
Description was changed from ========== iSAC: Remove unnecessary WEBRTC_LINUX define. I can only find one use in iSAC codebase: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... It's the prime suspect for causing a compilation error for iOS failing to include linux/net.h which is being included in webrtc/voice_engine/voice_engine_defines.h NOTRY=True ========== to ========== iSAC: Remove unnecessary WEBRTC_LINUX define. I can only find one use in iSAC codebase: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... It's the prime suspect for causing a compilation error for iOS failing to include linux/net.h which is being included in webrtc/voice_engine/voice_engine_defines.h NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== iSAC: Remove unnecessary WEBRTC_LINUX define. I can only find one use in iSAC codebase: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... It's the prime suspect for causing a compilation error for iOS failing to include linux/net.h which is being included in webrtc/voice_engine/voice_engine_defines.h NOTRY=True ========== to ========== iSAC: Remove unnecessary WEBRTC_LINUX define. I can only find one use in iSAC codebase: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/webrtc... It's the prime suspect for causing a compilation error for iOS failing to include linux/net.h which is being included in webrtc/voice_engine/voice_engine_defines.h NOTRY=True Committed: https://crrev.com/740c367af39845dd79e190d57cfe9f6faa8ae3e5 Cr-Commit-Position: refs/heads/master@{#11089} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/740c367af39845dd79e190d57cfe9f6faa8ae3e5 Cr-Commit-Position: refs/heads/master@{#11089} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
