Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc

Issue 1539763004: Miscellaneous fixes to DataUse UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased, addressed megjablon comments Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc
diff --git a/chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc b/chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc
index cb215aa65d5efaead3c8f42516f4cb419c843d09..91d5dfe0d3ef9d3b8454957f56b0a4d83ee3c453 100644
--- a/chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc
+++ b/chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc
@@ -48,11 +48,46 @@ jboolean CheckDataUseTrackingEnded(JNIEnv* env,
}
// static
+void UserClickedContinueOnDialogBox(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ jint tab_id,
+ const JavaParamRef<jobject>& jprofile) {
+ Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
+ chrome::android::DataUseUITabModel* data_use_ui_tab_model =
+ chrome::android::DataUseUITabModelFactory::GetForBrowserContext(profile);
+ DCHECK_LE(0, static_cast<SessionID::id_type>(tab_id));
+ if (data_use_ui_tab_model) {
+ data_use_ui_tab_model->UserClickedContinueOnDialogBox(
+ static_cast<SessionID::id_type>(tab_id));
+ }
+}
+
+// static
+jboolean WouldDataUseTrackingEnd(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ jint tab_id,
+ const JavaParamRef<jstring>& url,
+ jint transition_type,
+ const JavaParamRef<jstring>& package_name,
+ const JavaParamRef<jobject>& jprofile) {
+ Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
+ chrome::android::DataUseUITabModel* data_use_ui_tab_model =
+ chrome::android::DataUseUITabModelFactory::GetForBrowserContext(profile);
+ DCHECK_LE(0, static_cast<SessionID::id_type>(tab_id));
+ if (data_use_ui_tab_model) {
+ return data_use_ui_tab_model->WouldDataUseTrackingEnd(
+ ConvertJavaStringToUTF8(env, url), transition_type,
+ static_cast<SessionID::id_type>(tab_id));
+ }
+ return false;
+}
+
+// static
void OnCustomTabInitialNavigation(JNIEnv* env,
const JavaParamRef<jclass>& clazz,
jint tab_id,
- const JavaParamRef<jstring>& url,
const JavaParamRef<jstring>& package_name,
+ const JavaParamRef<jstring>& url,
const JavaParamRef<jobject>& jprofile) {
Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
chrome::android::DataUseUITabModel* data_use_ui_tab_model =
@@ -61,8 +96,8 @@ void OnCustomTabInitialNavigation(JNIEnv* env,
if (data_use_ui_tab_model) {
data_use_ui_tab_model->ReportCustomTabInitialNavigation(
static_cast<SessionID::id_type>(tab_id),
- ConvertJavaStringToUTF8(env, url),
- ConvertJavaStringToUTF8(env, package_name));
+ ConvertJavaStringToUTF8(env, package_name),
+ ConvertJavaStringToUTF8(env, url));
}
}

Powered by Google App Engine
This is Rietveld 408576698