Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: chrome/browser/android/data_usage/data_use_tab_ui_manager_android.cc

Issue 1539763004: Miscellaneous fixes to DataUse UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased, addressed megjablon comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/data_usage/data_use_tab_ui_manager_android.h" 5 #include "chrome/browser/android/data_usage/data_use_tab_ui_manager_android.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 30 matching lines...) Expand all
41 chrome::android::DataUseUITabModelFactory::GetForBrowserContext(profile); 41 chrome::android::DataUseUITabModelFactory::GetForBrowserContext(profile);
42 DCHECK_LE(0, static_cast<SessionID::id_type>(tab_id)); 42 DCHECK_LE(0, static_cast<SessionID::id_type>(tab_id));
43 if (data_use_ui_tab_model) { 43 if (data_use_ui_tab_model) {
44 return data_use_ui_tab_model->HasDataUseTrackingEnded( 44 return data_use_ui_tab_model->HasDataUseTrackingEnded(
45 static_cast<SessionID::id_type>(tab_id)); 45 static_cast<SessionID::id_type>(tab_id));
46 } 46 }
47 return false; 47 return false;
48 } 48 }
49 49
50 // static 50 // static
51 void UserClickedContinueOnDialogBox(JNIEnv* env,
52 const JavaParamRef<jclass>& clazz,
53 jint tab_id,
54 const JavaParamRef<jobject>& jprofile) {
55 Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
56 chrome::android::DataUseUITabModel* data_use_ui_tab_model =
57 chrome::android::DataUseUITabModelFactory::GetForBrowserContext(profile);
58 DCHECK_LE(0, static_cast<SessionID::id_type>(tab_id));
59 if (data_use_ui_tab_model) {
60 data_use_ui_tab_model->UserClickedContinueOnDialogBox(
61 static_cast<SessionID::id_type>(tab_id));
62 }
63 }
64
65 // static
66 jboolean WouldDataUseTrackingEnd(JNIEnv* env,
67 const JavaParamRef<jclass>& clazz,
68 jint tab_id,
69 const JavaParamRef<jstring>& url,
70 jint transition_type,
71 const JavaParamRef<jstring>& package_name,
72 const JavaParamRef<jobject>& jprofile) {
73 Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
74 chrome::android::DataUseUITabModel* data_use_ui_tab_model =
75 chrome::android::DataUseUITabModelFactory::GetForBrowserContext(profile);
76 DCHECK_LE(0, static_cast<SessionID::id_type>(tab_id));
77 if (data_use_ui_tab_model) {
78 return data_use_ui_tab_model->WouldDataUseTrackingEnd(
79 ConvertJavaStringToUTF8(env, url), transition_type,
80 static_cast<SessionID::id_type>(tab_id));
81 }
82 return false;
83 }
84
85 // static
51 void OnCustomTabInitialNavigation(JNIEnv* env, 86 void OnCustomTabInitialNavigation(JNIEnv* env,
52 const JavaParamRef<jclass>& clazz, 87 const JavaParamRef<jclass>& clazz,
53 jint tab_id, 88 jint tab_id,
89 const JavaParamRef<jstring>& package_name,
54 const JavaParamRef<jstring>& url, 90 const JavaParamRef<jstring>& url,
55 const JavaParamRef<jstring>& package_name,
56 const JavaParamRef<jobject>& jprofile) { 91 const JavaParamRef<jobject>& jprofile) {
57 Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile); 92 Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
58 chrome::android::DataUseUITabModel* data_use_ui_tab_model = 93 chrome::android::DataUseUITabModel* data_use_ui_tab_model =
59 chrome::android::DataUseUITabModelFactory::GetForBrowserContext(profile); 94 chrome::android::DataUseUITabModelFactory::GetForBrowserContext(profile);
60 DCHECK_LE(0, static_cast<SessionID::id_type>(tab_id)); 95 DCHECK_LE(0, static_cast<SessionID::id_type>(tab_id));
61 if (data_use_ui_tab_model) { 96 if (data_use_ui_tab_model) {
62 data_use_ui_tab_model->ReportCustomTabInitialNavigation( 97 data_use_ui_tab_model->ReportCustomTabInitialNavigation(
63 static_cast<SessionID::id_type>(tab_id), 98 static_cast<SessionID::id_type>(tab_id),
64 ConvertJavaStringToUTF8(env, url), 99 ConvertJavaStringToUTF8(env, package_name),
65 ConvertJavaStringToUTF8(env, package_name)); 100 ConvertJavaStringToUTF8(env, url));
66 } 101 }
67 } 102 }
68 103
69 bool RegisterDataUseTabUIManager(JNIEnv* env) { 104 bool RegisterDataUseTabUIManager(JNIEnv* env) {
70 return RegisterNativesImpl(env); 105 return RegisterNativesImpl(env);
71 } 106 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698