Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 15385002: Change parallel test logic to run only with jobs>1 (Closed)

Created:
7 years, 7 months ago by Isaac (away)
Modified:
7 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Change parallel test logic to run only with jobs>1 Regular map is preferred when parallization does not speed presubmit tests. It makes stacktraces more understandable and facilitates debugging. Only use parallel pool when tests > 1. R=maruel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=200940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M presubmit_support.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Isaac (away)
7 years, 7 months ago (2013-05-18 00:06:56 UTC) #1
M-A Ruel
Good idea, lgtm.
7 years, 7 months ago (2013-05-18 01:19:02 UTC) #2
Isaac (away)
Yeah I noticed Ctrl-C spits out a lot of gibberish with the Pool control flow. ...
7 years, 7 months ago (2013-05-18 01:31:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/15385002/1
7 years, 7 months ago (2013-05-18 01:32:44 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-18 01:34:16 UTC) #5
Message was sent while issue was closed.
Change committed as 200940

Powered by Google App Engine
This is Rietveld 408576698