presubmit_support.py - Issue 15385002: Change parallel test logic to run only with jobs>1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 15385002: Change parallel test logic to run only with jobs>1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index 23cc5e427ab9cfe101e5cdc0ad65da14e0312807..9baee8c5c0b90d51ada1fa560dc338b90b44a802 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -478,7 +478,7 @@ class InputApi(object):

else:

assert issubclass(t.message, _PresubmitResult)

tests.append(t)

- if tests and parallel:

+ if len(tests) > 1 and parallel:

pool = multiprocessing.Pool()

# async recipe works around multiprocessing bug handling Ctrl-C

msgs.extend(pool.map_async(CallCommand, tests).get(99999))

« no previous file with comments | « no previous file | no next file » | no next file with comments »