Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 15380003: Rename test callbacks for CookieStore to represent the argument type. (Closed)

Created:
7 years, 7 months ago by tyoshino (SeeGerritForStatus)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), cbentzel+watch_chromium.org
Visibility:
Public.

Description

Rename test callbacks for CookieStore to represent the argument type. These callbacks are not tightly connected to each method but are made to save a result value of the specified type. Rename them to represent the type. Actually, SetCookieCallback is used for testing Delete method which passes a bool result to the done callback. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -90 lines) Patch
M net/cookies/cookie_monster_unittest.cc View 9 chunks +30 lines, -27 lines 0 comments Download
M net/cookies/cookie_store_test_callbacks.h View 2 chunks +20 lines, -20 lines 0 comments Download
M net/cookies/cookie_store_test_callbacks.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M net/cookies/cookie_store_unittest.h View 10 chunks +39 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tyoshino (SeeGerritForStatus)
7 years, 7 months ago (2013-05-20 07:30:13 UTC) #1
erikwright (departed)
LGTM. Bonus points for coalescing the three redundant class definitions into a template like CookieResultCallback<std::string>. ...
7 years, 7 months ago (2013-05-22 01:33:33 UTC) #2
tyoshino (SeeGerritForStatus)
On 2013/05/22 01:33:33, erikwright wrote: > LGTM. Bonus points for coalescing the three redundant class ...
7 years, 7 months ago (2013-05-22 02:26:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/15380003/1
7 years, 7 months ago (2013-05-22 02:26:14 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-22 12:43:41 UTC) #5
Message was sent while issue was closed.
Change committed as 201497

Powered by Google App Engine
This is Rietveld 408576698