Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1113)

Unified Diff: net/cookies/cookie_store_test_callbacks.h

Issue 15380003: Rename test callbacks for CookieStore to represent the argument type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | net/cookies/cookie_store_test_callbacks.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_store_test_callbacks.h
diff --git a/net/cookies/cookie_store_test_callbacks.h b/net/cookies/cookie_store_test_callbacks.h
index ad6f77eb087fd15a80a23807ca5fe19efea6b474..c8308e1bc391089020651f0191e08bcca3cb91e1 100644
--- a/net/cookies/cookie_store_test_callbacks.h
+++ b/net/cookies/cookie_store_test_callbacks.h
@@ -48,10 +48,10 @@ class CookieCallback {
// Callback implementations for the asynchronous CookieStore methods.
-class SetCookieCallback : public CookieCallback {
+class BoolResultCookieCallback : public CookieCallback {
public:
- SetCookieCallback();
- explicit SetCookieCallback(base::Thread* run_in_thread);
+ BoolResultCookieCallback();
+ explicit BoolResultCookieCallback(base::Thread* run_in_thread);
void Run(bool result) {
result_ = result;
@@ -64,42 +64,42 @@ class SetCookieCallback : public CookieCallback {
bool result_;
};
-class GetCookieStringCallback : public CookieCallback {
+class StringResultCookieCallback : public CookieCallback {
public:
- GetCookieStringCallback();
- explicit GetCookieStringCallback(base::Thread* run_in_thread);
+ StringResultCookieCallback();
+ explicit StringResultCookieCallback(base::Thread* run_in_thread);
- void Run(const std::string& cookie) {
- cookie_ = cookie;
+ void Run(const std::string& result) {
+ result_ = result;
CallbackEpilogue();
}
- const std::string& cookie() { return cookie_; }
+ const std::string& result() { return result_; }
private:
- std::string cookie_;
+ std::string result_;
};
-class DeleteCallback : public CookieCallback {
+class IntResultCookieCallback : public CookieCallback {
public:
- DeleteCallback();
- explicit DeleteCallback(base::Thread* run_in_thread);
+ IntResultCookieCallback();
+ explicit IntResultCookieCallback(base::Thread* run_in_thread);
- void Run(int num_deleted) {
- num_deleted_ = num_deleted;
+ void Run(int result) {
+ result_ = result;
CallbackEpilogue();
}
- int num_deleted() { return num_deleted_; }
+ int result() { return result_; }
private:
- int num_deleted_;
+ int result_;
};
-class DeleteCookieCallback : public CookieCallback {
+class NoResultCookieCallback : public CookieCallback {
public:
- DeleteCookieCallback();
- explicit DeleteCookieCallback(base::Thread* run_in_thread);
+ NoResultCookieCallback();
+ explicit NoResultCookieCallback(base::Thread* run_in_thread);
void Run() {
CallbackEpilogue();
« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | net/cookies/cookie_store_test_callbacks.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698