Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: src/trusted/validator_mips/model.h

Issue 1535443005: [MIPS] Make validator allow only two load patterns via $t8 (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client@master
Patch Set: Update per code review. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_mips/model.h
diff --git a/src/trusted/validator_mips/model.h b/src/trusted/validator_mips/model.h
index 12a268ccefe9ae49b0d23151d2d43549181ed12e..dd875205f45a91723345bab3c3d75c1f2a252c5d 100644
--- a/src/trusted/validator_mips/model.h
+++ b/src/trusted/validator_mips/model.h
@@ -42,7 +42,8 @@ class Register {
static const Number kJumpMask = 14; // $t6 = holds mask for jr.
static const Number kLoadStoreMask = 15; // $t7 = holds mask for load/store.
- static const Number kTls = 24; // $t8 = holds tls index.
+ static const Number kTls = 24; // $t8 = holds address of
+ // tls_value1 in NaClThreadContext.
static const Number kSp = 29; // Stack pointer.
static const Number kNone = 32;
@@ -174,7 +175,7 @@ uint32_t const kBundleAlign = 0xFFFFFFF0;
// Opcode for nop instruction.
uint32_t const kNop = 0x0;
-} // namespace
+} // namespace nacl_mips_dec
// Definitions for our inlined functions.
#include "native_client/src/trusted/validator_mips/model-inl.h"

Powered by Google App Engine
This is Rietveld 408576698