src/trusted/validator_mips/validation-report.py - Issue 1535443005: [MIPS] Make validator allow only two load patterns via $t8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_mips/validation-report.py

Issue 1535443005: [MIPS] Make validator allow only two load patterns via $t8 (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client@master

Patch Set: Update per code review. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/trusted/validator_mips/validation-report.py

diff --git a/src/trusted/validator_mips/validation-report.py b/src/trusted/validator_mips/validation-report.py

index 34dc476bf93f89a2b16bb74ffaca1aa118872b61..6618e17908f79e8e88a8facb349147c35257044c 100755

--- a/src/trusted/validator_mips/validation-report.py

+++ b/src/trusted/validator_mips/validation-report.py

@@ -51,6 +51,9 @@ def _problem_info(code):

'kProblemUnsafeLoadStore': ['This load/store instruction is not '

'preceded by a valid store mask instruction',

1, 0],

+ 'kProblemUnsafeLoadStoreThreadPointer': ['This is not a valid'

Mark Seaborn 2015/12/30 02:12:40 Add space before the last single quote

petarj 2015/12/30 17:04:58 Done.

+ 'load/store instruction for accessing thread pointer.',

+ 0, 0],

'kProblemUnsafeJumpRegister': ['This indirect jump instruction is not '

'preceded by a valid jump mask instruction',

1, 0],

« no previous file with comments | « src/trusted/validator_mips/testdata/test_tp_access.err ('k') | src/trusted/validator_mips/validator.h » ('j') | no next file with comments »