Issue 15333012: [Password Autofill] Fix password Autofill on Facebook and Gmail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15333012: [Password Autofill] Fix password Autofill on Facebook and Gmail. (Closed)

Created:
7 years, 7 months ago by Ilya Sherman

Modified:
7 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Password Autofill] Fix password Autofill on Facebook and Gmail. BUG=227482 TEST=(see bug for repro steps) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201405

Patch Set 1 #

Patch Set 2 : Update test #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -10 lines)			Patch
M	components/autofill/browser/autofill_external_delegate.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download
M	components/autofill/browser/autofill_external_delegate_unittest.cc	View	1	4 chunks	+10 lines, -4 lines	0 comments	Download
M	components/autofill/browser/autofill_manager.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/15333012/2017

7 years, 7 months ago (2013-05-21 21:27:02 UTC) #3

Message was sent while issue was closed.

Change committed as 201405

Expand Messages | Collapse Messages