Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: components/autofill/browser/autofill_external_delegate.cc

Issue 15333012: [Password Autofill] Fix password Autofill on Facebook and Gmail. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update test Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/browser/autofill_external_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/browser/autofill_external_delegate.cc
diff --git a/components/autofill/browser/autofill_external_delegate.cc b/components/autofill/browser/autofill_external_delegate.cc
index 0286b4bff18ba5536edaf62cce86c59ab4dd35d8..95fc0cfd74500192a39b715dc7eb5f65b1341a08 100644
--- a/components/autofill/browser/autofill_external_delegate.cc
+++ b/components/autofill/browser/autofill_external_delegate.cc
@@ -206,11 +206,10 @@ void AutofillExternalDelegate::DidAcceptSuggestion(const base::string16& value,
} else if (identifier == WebAutofillClient::MenuItemIDClearForm) {
// User selected 'Clear form'.
host->Send(new AutofillMsg_ClearForm(host->GetRoutingID()));
- } else if (identifier == WebAutofillClient::MenuItemIDPasswordEntry &&
- password_autofill_manager_.DidAcceptAutofillSuggestion(
- autofill_query_field_, value)) {
- // DidAcceptAutofillSuggestion has already handled the work to fill in
- // the page as required.
+ } else if (identifier == WebAutofillClient::MenuItemIDPasswordEntry) {
+ bool success = password_autofill_manager_.DidAcceptAutofillSuggestion(
+ autofill_query_field_, value);
+ DCHECK(success);
} else if (identifier == WebAutofillClient::MenuItemIDDataListEntry) {
host->Send(new AutofillMsg_AcceptDataListSuggestion(host->GetRoutingID(),
value));
« no previous file with comments | « no previous file | components/autofill/browser/autofill_external_delegate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698