Issue 15301006: Merged GraphicsContext3DPrivate into GraphicsContext3D

Issue 15301006: Merged GraphicsContext3DPrivate into GraphicsContext3D (Closed)

Created:
7 years, 7 months ago by bajones

Modified:
7 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit), Zhenyao Mo, greggman, jamesr

CC:
blink-reviews, jamesr, eae+blinkwatch, danakj, feature-media-reviews_chromium.org, Rik, adamk+blink_chromium.org, Stephen Chennney, jeez, pdr.

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Merged GraphicsContext3DPrivate into GraphicsContext3D Also took the opportunity to remove some dead code. BUG=241820 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150605

Patch Set 3 : Removed ExtractWebGraphicsContext3D #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+444 lines, -641 lines)			Patch
M	Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp	View	1 2	3 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/src/WebViewImpl.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/WebKit/chromium/tests/Canvas2DLayerBridgeTest.cpp	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/WebKit/chromium/tests/DrawingBufferTest.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/core.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/canvas/WebGLRenderingContext.cpp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/core/platform/chromium/support/GraphicsContext3DPrivate.h	View		1 chunk	+0 lines, -129 lines	0 comments	Download
D	Source/core/platform/chromium/support/GraphicsContext3DPrivate.cpp	View		1 chunk	+0 lines, -372 lines	0 comments	Download
M	Source/core/platform/graphics/Extensions3D.h	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/platform/graphics/Extensions3D.cpp	View		4 chunks	+34 lines, -35 lines	0 comments	Download
M	Source/core/platform/graphics/GraphicsContext3D.h	View	1 2	7 chunks	+72 lines, -14 lines	0 comments	Download
M	Source/core/platform/graphics/GraphicsContext3D.cpp	View	1 2	15 chunks	+317 lines, -61 lines	0 comments	Download
M	Source/core/platform/graphics/chromium/Canvas2DLayerBridge.cpp	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/platform/graphics/gpu/DrawingBuffer.cpp	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/core/platform/graphics/gpu/SharedGraphicsContext3D.cpp	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bajones

Trying to further clean up the core WebGL code paths in Blink.

7 years, 7 months ago (2013-05-17 18:17:34 UTC) #1

greggman

On 2013/05/17 18:17:34, bajones wrote: > Trying to further clean up the core WebGL code ...

7 years, 7 months ago (2013-05-17 19:17:06 UTC) #2

jamesr

lgtm2 https://codereview.chromium.org/15301006/diff/1/Source/core/platform/graphics/Extensions3D.h File Source/core/platform/graphics/Extensions3D.h (right): https://codereview.chromium.org/15301006/diff/1/Source/core/platform/graphics/Extensions3D.h#newcode335 Source/core/platform/graphics/Extensions3D.h:335: // Weak pointer back to GraphicsContext3DPrivate please update ...

7 years, 7 months ago (2013-05-17 19:26:02 UTC) #3

Zhenyao Mo

Otherwise LGTM https://codereview.chromium.org/15301006/diff/1/Source/core/platform/graphics/GraphicsContext3D.h File Source/core/platform/graphics/GraphicsContext3D.h (right): https://codereview.chromium.org/15301006/diff/1/Source/core/platform/graphics/GraphicsContext3D.h#newcode450 Source/core/platform/graphics/GraphicsContext3D.h:450: static WebKit::WebGraphicsContext3D* extractWebGraphicsContext3D(GraphicsContext3D*); This is no longer ...

7 years, 7 months ago (2013-05-17 19:38:45 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/15301006/8001

7 years, 7 months ago (2013-05-17 19:54:19 UTC) #5

Message was sent while issue was closed.

LGTM FWIW.

Expand Messages | Collapse Messages