Switch from build-time to run-time flags for Project Spitzer.

Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.
http://crbug.com/570711 tracks this size increase and plans to reduce it in
the future.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL

BUG=507834, 570711, 570762
TEST=builds with gn/gyp work with unified path.
TBR=grt@chromium.org,dpranke@chromium.org

[DaleCurtis, 2015-12-16 00:05:38]

Description was changed from

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~600k uncompressed binary size increase
on Android and has been approved via Chrome Eng Review + klobag@ from
the Chrome for Android team. It paves the way for unifying our playback
stacks across platforms and brings previously-missing features and
improved security to Android playback. More technical details can
be found in the linked bug below and design doc: https://goo.gl/qC3OuL

A follow up CL will add this functionality to chrome://flags

BUG=507834
TEST=builds with gn/gyp work with unified path.
==========

to

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

<-----PENDING APPROVAL, NOT FOR SUBMISSION INTO APPROVAL !!----->
This change will result in a ~600k uncompressed binary size increase
on Android and has been approved via Chrome Eng Review + klobag@ from
the Chrome for Android team. It paves the way for unifying our playback
stacks across platforms and brings previously-missing features and
improved security to Android playback. More technical details can
be found in the linked bug below and design doc: https://goo.gl/qC3OuL
<-----PENDING APPROVAL, NOT FOR SUBMISSION INTO APPROVAL !!----->

A follow up CL will add this functionality to chrome://flags

BUG=507834
TEST=builds with gn/gyp work with unified path.
==========

[DaleCurtis, 2015-12-16 00:05:39]

dalecurtis@chromium.org changed reviewers:
+ xhwang@chromium.org

[DaleCurtis, 2015-12-16 00:06:40]

dalecurtis@chromium.org changed reviewers:
+ liberato@chromium.org

[DaleCurtis, 2015-12-16 00:06:41]

https://codereview.chromium.org/1530063002/diff/1/content/common/gpu/media/an...
File content/common/gpu/media/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1530063002/diff/1/content/common/gpu/media/an...
content/common/gpu/media/android_video_decode_accelerator.cc:94: //
TODO(liberato): This should be based on the command line flags present
liberato@, approved your CL here: https://codereview.chromium.org/1515993003/

https://codereview.chromium.org/1530063002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1530063002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:217: #if defined(ENABLE_MOJO_MEDIA) // &&
TODO(xhwang): What condition to make this?
Xiaohan, what do you want to do with these?

[DaleCurtis, 2015-12-16 00:06:58]

Description was changed from

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

<-----PENDING APPROVAL, NOT FOR SUBMISSION INTO APPROVAL !!----->
This change will result in a ~600k uncompressed binary size increase
on Android and has been approved via Chrome Eng Review + klobag@ from
the Chrome for Android team. It paves the way for unifying our playback
stacks across platforms and brings previously-missing features and
improved security to Android playback. More technical details can
be found in the linked bug below and design doc: https://goo.gl/qC3OuL
<-----PENDING APPROVAL, NOT FOR SUBMISSION INTO APPROVAL !!----->

A follow up CL will add this functionality to chrome://flags

BUG=507834
TEST=builds with gn/gyp work with unified path.
==========

to

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

<-----PENDING APPROVAL, NOT FOR SUBMISSION UNTIL APPROVAL !!----->
This change will result in a ~600k uncompressed binary size increase
on Android and has been approved via Chrome Eng Review + klobag@ from
the Chrome for Android team. It paves the way for unifying our playback
stacks across platforms and brings previously-missing features and
improved security to Android playback. More technical details can
be found in the linked bug below and design doc: https://goo.gl/qC3OuL
<-----PENDING APPROVAL, NOT FOR SUBMISSION UNTIL APPROVAL !!----->

A follow up CL will add this functionality to chrome://flags

BUG=507834
TEST=builds with gn/gyp work with unified path.
==========

[xhwang, 2015-12-17 01:09:59]

sorry for the delayed response. I somehow missed it..

https://codereview.chromium.org/1530063002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1530063002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:217: #if defined(ENABLE_MOJO_MEDIA) // &&
TODO(xhwang): What condition to make this?
On 2015/12/16 00:06:40, DaleCurtis_OOO_Until_Jan_5 wrote:
> Xiaohan, what do you want to do with these?

How about 

#if defined(ENABLE_MOJO_MEDIA) && !defined(OS_ANDROID)

for now? I'll refine this later (before the branch cut). ENABLE_MOJO_MEDIA is
not enabled by default so this won't cause any issues.

[DaleCurtis, 2015-12-17 01:23:23]

https://codereview.chromium.org/1530063002/diff/1/content/renderer/render_fra...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1530063002/diff/1/content/renderer/render_fra...
content/renderer/render_frame_impl.cc:217: #if defined(ENABLE_MOJO_MEDIA) // &&
TODO(xhwang): What condition to make this?
On 2015/12/17 01:09:58, xhwang wrote:
> On 2015/12/16 00:06:40, DaleCurtis_OOO_Until_Jan_5 wrote:
> > Xiaohan, what do you want to do with these?
> 
> How about 
> 
> #if defined(ENABLE_MOJO_MEDIA) && !defined(OS_ANDROID)
> 
> for now? I'll refine this later (before the branch cut). ENABLE_MOJO_MEDIA is
> not enabled by default so this won't cause any issues.

Sounds good to me; I wasn't sure if Cast or some other product needed
ANDROID+MOJO in some case.

[DaleCurtis, 2015-12-17 01:24:07]

Description was changed from

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

<-----PENDING APPROVAL, NOT FOR SUBMISSION UNTIL APPROVAL !!----->
This change will result in a ~600k uncompressed binary size increase
on Android and has been approved via Chrome Eng Review + klobag@ from
the Chrome for Android team. It paves the way for unifying our playback
stacks across platforms and brings previously-missing features and
improved security to Android playback. More technical details can
be found in the linked bug below and design doc: https://goo.gl/qC3OuL
<-----PENDING APPROVAL, NOT FOR SUBMISSION UNTIL APPROVAL !!----->

A follow up CL will add this functionality to chrome://flags

BUG=507834
TEST=builds with gn/gyp work with unified path.
==========

to

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

<-----PENDING APPROVAL, NOT FOR SUBMISSION UNTIL APPROVAL !!----->
This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL
<-----PENDING APPROVAL, NOT FOR SUBMISSION UNTIL APPROVAL !!----->

A follow up CL will add this functionality to chrome://flags

BUG=507834
TEST=builds with gn/gyp work with unified path.
==========

[DaleCurtis, 2015-12-17 01:50:48]

https://codereview.chromium.org/1530063002/diff/1/content/common/gpu/media/an...
File content/common/gpu/media/android_video_decode_accelerator.cc (right):

https://codereview.chromium.org/1530063002/diff/1/content/common/gpu/media/an...
content/common/gpu/media/android_video_decode_accelerator.cc:94: //
TODO(liberato): This should be based on the command line flags present
On 2015/12/16 00:06:40, DaleCurtis_OOO_Until_Jan_5 wrote:
> liberato@, approved your CL here: https://codereview.chromium.org/1515993003/

Rebased on Frank's changes.

[DaleCurtis, 2015-12-17 01:52:48]

Patchset #2 (id:20001) has been deleted

[DaleCurtis, 2015-12-17 01:53:44]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 02:36:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530063002/40001

[commit-bot: I haz the power, 2015-12-17 03:27:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 03:27:30]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[DaleCurtis, 2015-12-17 20:58:05]

Description was changed from

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

<-----PENDING APPROVAL, NOT FOR SUBMISSION UNTIL APPROVAL !!----->
This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL
<-----PENDING APPROVAL, NOT FOR SUBMISSION UNTIL APPROVAL !!----->

A follow up CL will add this functionality to chrome://flags

BUG=507834
TEST=builds with gn/gyp work with unified path.
==========

to

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.
http://crbug.com/570711 tracks this size increase and plans to reduce it in
the future.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL

BUG=507834, 570711
TEST=builds with gn/gyp work with unified path.
==========

[DaleCurtis, 2015-12-17 20:58:33]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 20:59:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530063002/60001

[DaleCurtis, 2015-12-17 21:02:03]

dalecurtis@chromium.org changed reviewers:
+ creis@chromium.org, dpranke@chromium.org, grt@chromium.org

[DaleCurtis, 2015-12-17 21:02:03]

We have approval from Grace now to land this. I've fixed up a few build failures
and sent it off for tries again.

+dpranke for build/ changes
+creis for content/renderer changes
+tbr=grt for chrome/app/generated_resources.grd changes

[DaleCurtis, 2015-12-17 21:02:22]

Description was changed from

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.
http://crbug.com/570711 tracks this size increase and plans to reduce it in
the future.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL

BUG=507834, 570711
TEST=builds with gn/gyp work with unified path.
==========

to

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.
http://crbug.com/570711 tracks this size increase and plans to reduce it in
the future.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL

BUG=507834, 570711
TEST=builds with gn/gyp work with unified path.
TBR=grt
==========

[Charlie Reis, 2015-12-17 21:52:29]

content/renderer LGTM

[DaleCurtis, 2015-12-17 22:10:07]

dalecurtis@chromium.org changed reviewers:
+ isherman@chromium.org

[DaleCurtis, 2015-12-17 22:10:07]

+isherman for histograms.xml change.

[DaleCurtis, 2015-12-17 22:10:46]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-17 22:13:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530063002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530063002/80001

[Ilya Sherman, 2015-12-17 22:23:59]

histograms.xml lgtm

[DaleCurtis, 2015-12-18 00:05:03]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 00:08:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530063002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530063002/100001

[commit-bot: I haz the power, 2015-12-18 03:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 03:26:25]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[DaleCurtis, 2015-12-18 07:45:44]

Description was changed from

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.
http://crbug.com/570711 tracks this size increase and plans to reduce it in
the future.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL

BUG=507834, 570711
TEST=builds with gn/gyp work with unified path.
TBR=grt
==========

to

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.
http://crbug.com/570711 tracks this size increase and plans to reduce it in
the future.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL

BUG=507834, 570711, 570762
TEST=builds with gn/gyp work with unified path.
TBR=grt
==========

[DaleCurtis, 2015-12-18 07:46:44]

The CQ bit was checked by dalecurtis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 07:47:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530063002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530063002/120001

[commit-bot: I haz the power, 2015-12-18 09:03:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 09:03:33]

Dry run: This issue passed the CQ dry run.

[xhwang, 2015-12-18 18:23:47]

Dirk Pranke: Please take a look at BUILD.gn and build/* changes. Thanks!

[xhwang, 2015-12-18 19:57:59]

On 2015/12/18 18:23:47, xhwang wrote:
> Dirk Pranke: Please take a look at BUILD.gn and build/* changes. Thanks!

Dirk Pranke: Actually the changes in BUILD.gn and build/* seem trivial IMHO. I
am gonna TRB you on those changes and go ahead and land this CL. Please let me
know if you do want to take a look. Otherwise I'll check the CQ box after
lunch...

[xhwang, 2015-12-18 19:58:26]

Description was changed from

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.
http://crbug.com/570711 tracks this size increase and plans to reduce it in
the future.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL

BUG=507834, 570711, 570762
TEST=builds with gn/gyp work with unified path.
TBR=grt
==========

to

==========
Switch from build-time to run-time flags for Project Spitzer.

This puts the desktop media playback pipeline behind a runtime flag
for Android; previously this was a combination of build-time and
run-time flags to avoid introducing a binary size increase before
we were ready for experiments.

This change will result in a ~480kb apk size increase on Android that has been
approved via Chrome Eng Review and klobag@ from the Chrome for Android team.
http://crbug.com/570711 tracks this size increase and plans to reduce it in
the future.

It paves the way for unifying our playback stacks across platforms and brings
previously-missing features and improved security to Android playback. More
technical details can be found in the linked bug below and design doc:
https://goo.gl/qC3OuL

BUG=507834, 570711, 570762
TEST=builds with gn/gyp work with unified path.
TBR=grt@chromium.org,dpranke@chromium.org
==========

[Dirk Pranke, 2015-12-18 21:21:26]

lgtm

[xhwang, 2015-12-18 21:26:33]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2015-12-18 21:26:33]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
isherman@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/1530063002/#ps120001 (title: "Disable
tests confused by codec support.")

[commit-bot: I haz the power, 2015-12-18 21:27:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530063002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530063002/120001

[commit-bot: I haz the power, 2015-12-18 21:34:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 21:34:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xhwang, 2015-12-18 21:59:37]

On 2015/12/18 21:34:42, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

I can't rebase/update this issue since it's owned by dalecurtis@. I uploaded to
new one to land this: https://chromiumcodereview.appspot.com/1541513002/

All existing reviewers are TBR'ed on that issue. Sorry for the noise.