Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 15300017: Pull string constants into separate .cc for split dll build (Closed)

Created:
7 years, 7 months ago by scottmg
Modified:
7 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Pull string constants into separate .cc for split dll build Requires https://codereview.chromium.org/15310002/ before landing. TBR=brettw@chromium.org R=cpu@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201264

Patch Set 1 #

Patch Set 2 : partition string constants #

Patch Set 3 : rebase #

Patch Set 4 : fix export 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -54 lines) Patch
M base/base.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M base/string_util.cc View 1 2 3 1 chunk +0 lines, -48 lines 0 comments Download
A base/string_util_constants.cc View 1 2 3 1 chunk +55 lines, -0 lines 0 comments Download
M build/split_link_partition.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/win/split_link/split_link.py View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scottmg
brettw: base/* (just moves) cpu: others
7 years, 7 months ago (2013-05-20 16:48:35 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 7 months ago (2013-05-21 01:33:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/15300017/1001
7 years, 7 months ago (2013-05-21 02:11:26 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-21 02:33:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/15300017/19001
7 years, 7 months ago (2013-05-21 03:23:26 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-21 08:37:31 UTC) #6
Message was sent while issue was closed.
Change committed as 201264

Powered by Google App Engine
This is Rietveld 408576698