Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: tools/win/split_link/split_link.py

Issue 15300017: Pull string constants into separate .cc for split dll build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix export 2 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/split_link_partition.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/win/split_link/split_link.py
diff --git a/tools/win/split_link/split_link.py b/tools/win/split_link/split_link.py
index 72b6c47290d77c88f004f0db687a4f28229b9e96..ee70c0efdecaa50bf12812b6e5561cfb42264a42 100644
--- a/tools/win/split_link/split_link.py
+++ b/tools/win/split_link/split_link.py
@@ -378,12 +378,10 @@ def main():
deffiles = GenerateDefFiles(unresolved_by_part)
import_libs = BuildImportLibs(flags, inputs_by_part, deffiles)
else:
- return 1
-
- if data_exports:
- print 'Data exports found, see report above.'
- print('These cannot be exported, and must be either duplicated to the '
- 'target DLL, or wrapped in a function.')
+ if data_exports:
+ print '%d data exports found, see report above.' % data_exports
+ print('These cannot be exported, and must be either duplicated to the '
+ 'target DLL (if constant), or wrapped in a function.')
return 1
mt_exe = GetMtPath()
« no previous file with comments | « build/split_link_partition.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698