Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 15299006: [downloads] Remove erroneous comment about redirects (Closed)

Created:
7 years, 7 months ago by cbentzel
Modified:
7 years, 7 months ago
Reviewers:
benjhayden
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka, darin-cc_chromium.org, jam, joi+watch-content_chromium.org
Visibility:
Public.

Description

[downloads] Remove erroneous comment about redirects. DownloadResourceHandler may go through redirects for non-navigation triggered downloads, such as "Save Link As..." or extension triggered downloads. BUG=114487 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/browser/download/download_resource_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
cbentzel
7 years, 7 months ago (2013-05-17 15:56:09 UTC) #1
cbentzel
Updated CL description, which was overly generic.
7 years, 7 months ago (2013-05-17 15:57:29 UTC) #2
benjhayden
lgtm
7 years, 7 months ago (2013-05-17 16:33:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/15299006/1
7 years, 7 months ago (2013-05-17 16:37:01 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=150348
7 years, 7 months ago (2013-05-17 18:43:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/15299006/1
7 years, 7 months ago (2013-05-17 18:52:57 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 22:16:29 UTC) #7
Message was sent while issue was closed.
Change committed as 200900

Powered by Google App Engine
This is Rietveld 408576698