Issue 15298013: ui: Inline QuadF::BoundingBox()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15298013: ui: Inline QuadF::BoundingBox() (Closed)

Created:
7 years, 7 months ago by danakj

Modified:
7 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, cc-bugs_chromium.org, backer, piman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ui: Inline QuadF::BoundingBox() This is a hot method, used every time we map a rect from one space to another, which accounts for a significant amount of total work done by the compositor. This change is a small perf improvement in cc_perftests, taking the ImplSidePaintingPerfTest.HeavyPage test from about 0.97 ms/commit to about 0.94 ms/commit. R=sky BUG=239684 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200952

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	ui/gfx/quad_f.h	View		2 chunks	+8 lines, -1 line	0 comments	Download
	M	ui/gfx/quad_f.cc	View		2 chunks	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/15298013/1

7 years, 7 months ago (2013-05-17 21:25:20 UTC) #3

Message was sent while issue was closed.

Change committed as 200952

Expand Messages | Collapse Messages