Translate: enable against unknown languages with server side detection

chrome/browser/tab_contents/render_view_context_menu.cc

Index: chrome/browser/tab_contents/render_view_context_menu.cc
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index ad04d13ccb11812499cbba15b51456de989ab4a9..6bd538405486e76e32864cadeeaa9bb704b0d33d 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -1206,17 +1206,11 @@ bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {
       // target languages are identical.  This is to give a way to user to
       // translate a page that might contains text fragments in a different
       // language.
-      return !!(params_.edit_flags & WebContextMenuData::CanTranslate) &&
+      return ((params_.edit_flags & WebContextMenuData::CanTranslate) != 0) &&
              translate_tab_helper->language_state().page_translatable() &&
              !original_lang.empty() &&  // Did we receive the page language yet?
-             // Only allow translating languages we explitly support and the
-             // unknown language (in which case the page language is detected on
-             // the server side).
-             (original_lang == chrome::kUnknownLanguageCode ||
-                 TranslateManager::IsSupportedLanguage(original_lang)) &&
              !translate_tab_helper->language_state().IsPageTranslated() &&
              !source_web_contents_->GetInterstitialPage() &&
-             TranslateManager::IsTranslatableURL(params_.page_url) &&

[MAD, 2013/05/17 17:33:11]

Why did you remove this? I don't think we want to translate these pages, and if
we do, we should handle this change separately from this change, which is about
a fallback, not adding new support for pages that we didn't want to translate
before.

[Takashi Toyoshima, 2013/05/17 17:57:07]

Sorry, I just mistakenly mix a part of another CL into this CL.

In another CL, I stop to add menu item itself when IsTranslatableURL() is false.
So, this check is redundant and is always true when this code path runs.

Anyway, I'll restore this line in this CL. 

[MAD, 2013/05/17 18:42:25]

Thanks!

[Takashi Toyoshima, 2013/05/20 06:56:08]

Done.

              // There are some application locales which can't be used as a
              // target language for translation.
              TranslateManager::IsSupportedLanguage(target_lang);