Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2808)

Unified Diff: chrome/browser/resources/translate.js

Issue 15295004: Translate: enable against unknown languages with server side detection (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/translate.js
diff --git a/chrome/browser/resources/translate.js b/chrome/browser/resources/translate.js
index 07f7113c19098a9aa32ea8a556b26f867bc9702e..047ce7c326eedccda287c9486efd13dd864d5c3b 100644
--- a/chrome/browser/resources/translate.js
+++ b/chrome/browser/resources/translate.js
@@ -135,6 +135,8 @@ cr.googleTranslate = (function(key) {
get sourceLang() {
if (!libReady || !finished || error)
return '';
+ if (!lib.getDetectedLanguage)
+ return 'und';
Evan Stade 2013/05/18 23:53:52 why 'und' and not undefined or 'undefined' or what
Takashi Toyoshima 2013/05/20 06:56:08 'und' is a magic word defined as chrome::kUnknownL
return lib.getDetectedLanguage();
Evan Stade 2013/05/18 23:53:52 you can write this as lib.getDetectedLanguage() ||
Takashi Toyoshima 2013/05/20 06:56:08 It doesn't work. Undefined one is not returned val
Evan Stade 2013/05/23 00:53:28 ah, I misread it
},

Powered by Google App Engine
This is Rietveld 408576698