Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java

Issue 1525793005: Move Tab's top controls visibility to a delegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java
index b112522a2016530bcdf192e5d0b5ccb390df6552..fa32d7338e1f82626e144d0a9651cbd20ebeaad9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java
@@ -14,6 +14,7 @@ import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabContextMenuItemDelegate;
import org.chromium.chrome.browser.tab.TabDelegateFactory;
import org.chromium.chrome.browser.tab.TabWebContentsDelegateAndroid;
+import org.chromium.chrome.browser.tab.TopControlsVisibilityDelegate;
/**
* A {@link TabDelegateFactory} class to be used in all {@link Tab} instances owned
@@ -61,4 +62,14 @@ public class FullScreenDelegateFactory extends TabDelegateFactory {
new TabContextMenuItemDelegate(tab, activity),
ChromeContextMenuPopulator.FULLSCREEN_TAB_MODE);
}
+
+ @Override
+ public TopControlsVisibilityDelegate createTopControlsVisibilityDelegate(Tab tab) {
+ return new TopControlsVisibilityDelegate(tab) {
+ @Override
+ public boolean isHidingTopControlsEnabled() {
+ return !isShowingTopControlsEnabled();
+ }
+ };
+ }
}

Powered by Google App Engine
This is Rietveld 408576698