Move Tab's top controls visibility to a delegate

Move Tab's top controls visibility to a delegate

- Adds TopControlsVisibilityDelegate to control top control visibility
- Adds a creator call for the delegate inside TabDelegateFactory
- Uses the delegateFactory to remove FullscreenActivityTab and
  CustomTab specific functionality

BUG=546182
Committed: https://crrev.com/0159fde750be8bd4fbc9fd277e96bab9bce90a3c
Cr-Commit-Position: refs/heads/master@{#365911}

[Yusuf, 2015-12-15 20:05:19]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2015-12-16 21:58:10]

lgtm

https://chromiumcodereview.appspot.com/1525793005/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://chromiumcodereview.appspot.com/1525793005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:268:
@Override
nit: indentation is screwed up

https://chromiumcodereview.appspot.com/1525793005/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java
(right):

https://chromiumcodereview.appspot.com/1525793005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java:14:
* A delegate to determine top controls visibility.
visibility of the top controls

https://chromiumcodereview.appspot.com/1525793005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java:35:
boolean enableHidingTopControls = url != null &&
!url.startsWith(UrlConstants.CHROME_SCHEME)
if you're breaking the other conditions into &=, you might as well do it here
too.

https://chromiumcodereview.appspot.com/1525793005/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
(right):

https://chromiumcodereview.appspot.com/1525793005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java:517:
// do not show top controls when URL is not ready yet.
Make this comment a full sentence.

[Yusuf, 2015-12-16 22:14:34]

https://codereview.chromium.org/1525793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/1525793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:268:
@Override
On 2015/12/16 21:58:10, dfalcantara wrote:
> nit: indentation is screwed up

Done.

https://codereview.chromium.org/1525793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java
(right):

https://codereview.chromium.org/1525793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java:14:
* A delegate to determine top controls visibility.
On 2015/12/16 21:58:10, dfalcantara wrote:
> visibility of the top controls

Done.

https://codereview.chromium.org/1525793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tab/TopControlsVisibilityDelegate.java:35:
boolean enableHidingTopControls = url != null &&
!url.startsWith(UrlConstants.CHROME_SCHEME)
On 2015/12/16 21:58:10, dfalcantara wrote:
> if you're breaking the other conditions into &=, you might as well do it here
> too.

Done.

https://codereview.chromium.org/1525793005/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
(right):

https://codereview.chromium.org/1525793005/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java:517:
// do not show top controls when URL is not ready yet.
On 2015/12/16 21:58:10, dfalcantara wrote:
> Make this comment a full sentence.

Done.

[Yusuf, 2015-12-16 22:15:54]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-12-16 22:15:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1525793005/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2015-12-16 22:16:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525793005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525793005/20001

[commit-bot: I haz the power, 2015-12-16 22:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 22:21:36]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Yusuf, 2015-12-16 22:27:51]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-12-16 22:27:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1525793005/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-12-16 22:28:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525793005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525793005/40001

[commit-bot: I haz the power, 2015-12-16 22:47:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 22:47:12]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yusuf, 2015-12-16 22:49:25]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-12-16 22:49:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1525793005/#ps60001
(title: "Fix compile error")

[commit-bot: I haz the power, 2015-12-16 22:51:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525793005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525793005/60001

[commit-bot: I haz the power, 2015-12-17 02:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 02:44:41]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yusuf, 2015-12-17 21:31:23]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-12-17 21:31:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1525793005/#ps80001
(title: "Fixed getContentViewCore related logic")

[commit-bot: I haz the power, 2015-12-17 21:33:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1525793005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1525793005/80001

[commit-bot: I haz the power, 2015-12-17 22:18:20]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-17 22:19:55]

Description was changed from

==========
Move Tab's top controls visibility to a delegate

- Adds TopControlsVisibilityDelegate to control top control visibility
- Adds a creator call for the delegate inside TabDelegateFactory
- Uses the delegateFactory to remove FullscreenActivityTab and
  CustomTab specific functionality

BUG=546182
==========

to

==========
Move Tab's top controls visibility to a delegate

- Adds TopControlsVisibilityDelegate to control top control visibility
- Adds a creator call for the delegate inside TabDelegateFactory
- Uses the delegateFactory to remove FullscreenActivityTab and
  CustomTab specific functionality

BUG=546182

Committed: https://crrev.com/0159fde750be8bd4fbc9fd277e96bab9bce90a3c
Cr-Commit-Position: refs/heads/master@{#365911}
==========

[commit-bot: I haz the power, 2015-12-17 22:19:56]

Patchset 5 (id:??) landed as
https://crrev.com/0159fde750be8bd4fbc9fd277e96bab9bce90a3c
Cr-Commit-Position: refs/heads/master@{#365911}