Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 15233003: ui: ToEnclosingRect(empty rect) should return an empty rect. (Closed)

Created:
7 years, 7 months ago by danakj
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, cc-bugs_chromium.org, backer, piman
Visibility:
Public.

Description

ui: ToEnclosingRect(empty rect) should return an empty rect. The RectF(5.5, 5.5, 0, 0) is empty, the enclosing integer rect should also be empty. Tests: RectTest.ToEnclosingRect R=sky BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200834

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/gfx/rect_conversions.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/rect_unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
7 years, 7 months ago (2013-05-16 21:50:06 UTC) #1
sky
LGTM
7 years, 7 months ago (2013-05-16 22:54:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/15233003/11001
7 years, 7 months ago (2013-05-17 14:01:07 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 17:08:45 UTC) #4
Message was sent while issue was closed.
Change committed as 200834

Powered by Google App Engine
This is Rietveld 408576698