Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: service/datastore/pls_impl.go

Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: Fix GetMetaDefault silliness Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« service/datastore/pls.go ('K') | « service/datastore/pls.go ('k') | service/datastore/pls_test.go » ('j') | service/datastore/pls_test.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/pls_impl.go
diff --git a/service/datastore/pls_impl.go b/service/datastore/pls_impl.go
index 2176b7e144ccd9e14c980ad22e7fdbe7dff4990d..4519abcc9fd72637efd1e85a8dfa862a9195eabf 100644
--- a/service/datastore/pls_impl.go
+++ b/service/datastore/pls_impl.go
@@ -352,10 +352,6 @@ func (p *structPLS) GetAllMeta() PropertyMap {
return ret
}
-func (p *structPLS) GetMetaDefault(key string, def interface{}) interface{} {
- return GetMetaDefaultImpl(p.GetMeta, key, def)
-}
-
func (p *structPLS) SetMeta(key string, val interface{}) (err error) {
if err = p.Problem(); err != nil {
return
« service/datastore/pls.go ('K') | « service/datastore/pls.go ('k') | service/datastore/pls_test.go » ('j') | service/datastore/pls_test.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698