Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: service/datastore/pls.go

Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: Fix GetMetaDefault silliness Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« filter/dscache/ds.go ('K') | « service/datastore/multiarg.go ('k') | service/datastore/pls_impl.go » ('j') | service/datastore/pls_test.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/pls.go
diff --git a/service/datastore/pls.go b/service/datastore/pls.go
index f1f54e683fc975bd293f31d8550c27708cec67d8..6e349283c181ce3a4c2c666761c78b6e6130742d 100644
--- a/service/datastore/pls.go
+++ b/service/datastore/pls.go
@@ -158,6 +158,7 @@ import (
func GetPLS(obj interface{}) interface {
PropertyLoadSaver
MetaGetterSetter
+ Problem() error
dnj 2015/12/11 06:36:17 Since Problem() is only used by tests, why export
} {
v := reflect.ValueOf(obj)
if v.Kind() != reflect.Ptr || v.Elem().Kind() != reflect.Struct {
« filter/dscache/ds.go ('K') | « service/datastore/multiarg.go ('k') | service/datastore/pls_impl.go » ('j') | service/datastore/pls_test.go » ('J')

Powered by Google App Engine
This is Rietveld 408576698