Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: impl/memory/datastore_test.go

Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: remove accidental extra test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: impl/memory/datastore_test.go
diff --git a/impl/memory/datastore_test.go b/impl/memory/datastore_test.go
index 681554de21d5c5d26b93dd4b86230f654642f601..269b5dea2100fd48e4e06137a341bf57dad8f742 100644
--- a/impl/memory/datastore_test.go
+++ b/impl/memory/datastore_test.go
@@ -145,7 +145,7 @@ func TestDatastoreSingleReadWriter(t *testing.T) {
vals := make([]dsS.PropertyMap, len(keys))
for i := range vals {
vals[i] = dsS.PropertyMap{}
- So(vals[i].SetMeta("key", keys[i]), ShouldBeNil)
+ So(vals[i].SetMeta("key", keys[i]), ShouldBeTrue)
}
So(ds.GetMulti(vals), ShouldBeNil)
@@ -243,10 +243,10 @@ func TestDatastoreSingleReadWriter(t *testing.T) {
ds := dsS.Get(c)
pm := dsS.PropertyMap{}
- So(pm.SetMeta("key", ds.NewKey("Foo", "", 20, nil)), ShouldBeNil)
+ So(pm.SetMeta("key", ds.NewKey("Foo", "", 20, nil)), ShouldBeTrue)
So(ds.Get(pm), ShouldEqual, dsS.ErrNoSuchEntity)
- So(pm.SetMeta("key", k), ShouldBeNil)
+ So(pm.SetMeta("key", k), ShouldBeTrue)
So(ds.Get(pm).Error(), ShouldContainSubstring, "cross-group")
return nil
}, nil)

Powered by Google App Engine
This is Rietveld 408576698