Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: filter/txnBuf/txnbuf_test.go

Issue 1516173002: Fix error message from KeyForObj when passing an invalid struct. (Closed) Base URL: https://github.com/luci/gae.git@master
Patch Set: remove accidental extra test Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: filter/txnBuf/txnbuf_test.go
diff --git a/filter/txnBuf/txnbuf_test.go b/filter/txnBuf/txnbuf_test.go
index 3aabcf88484ea0cd0736919a7e7c3a374c88b330..62ecba2d03d3a316a821d0327e2e357d4aac88bb 100644
--- a/filter/txnBuf/txnbuf_test.go
+++ b/filter/txnBuf/txnbuf_test.go
@@ -495,7 +495,8 @@ func TestQuerySupport(t *testing.T) {
}
for i, pm := range vals {
- So(pm.GetMetaDefault("key", nil), ShouldResemble, ds.MakeKey("Parent", 1, "Foo", expect[i].id))
+ So(datastore.GetMetaDefault(pm, "key", nil), ShouldResemble,
+ ds.MakeKey("Parent", 1, "Foo", expect[i].id))
So(pm["Value"][0].Value(), ShouldEqual, expect[i].val)
}
@@ -525,7 +526,8 @@ func TestQuerySupport(t *testing.T) {
}
for i, pm := range vals {
- So(pm.GetMetaDefault("key", nil), ShouldResemble, ds.MakeKey("Parent", 1, "Foo", expect[i].id))
+ So(datastore.GetMetaDefault(pm, "key", nil), ShouldResemble,
+ ds.MakeKey("Parent", 1, "Foo", expect[i].id))
So(pm["Value"][0].Value(), ShouldEqual, expect[i].val)
}
@@ -554,7 +556,8 @@ func TestQuerySupport(t *testing.T) {
}
for i, pm := range vals {
- So(pm.GetMetaDefault("key", nil), ShouldResemble, ds.MakeKey("Parent", 1, "Foo", expect[i].id))
+ So(datastore.GetMetaDefault(pm, "key", nil), ShouldResemble,
+ ds.MakeKey("Parent", 1, "Foo", expect[i].id))
So(pm["Value"][0].Value(), ShouldEqual, expect[i].val)
}
@@ -609,7 +612,8 @@ func TestQuerySupport(t *testing.T) {
for i, pm := range vals {
So(pm["Value"][0].Value(), ShouldEqual, expect[i].val)
- So(pm.GetMetaDefault("key", nil), ShouldResemble, ds.MakeKey("Parent", 1, "Foo", expect[i].id))
+ So(datastore.GetMetaDefault(pm, "key", nil), ShouldResemble,
+ ds.MakeKey("Parent", 1, "Foo", expect[i].id))
}
return nil
@@ -716,7 +720,8 @@ func TestQuerySupport(t *testing.T) {
for i, pm := range vals {
So(pm["Value"][0].Value(), ShouldEqual, expect[i].val)
- So(pm.GetMetaDefault("key", nil), ShouldResemble, ds.MakeKey("Parent", 1, "Foo", expect[i].id))
+ So(datastore.GetMetaDefault(pm, "key", nil), ShouldResemble,
+ ds.MakeKey("Parent", 1, "Foo", expect[i].id))
}
return nil

Powered by Google App Engine
This is Rietveld 408576698