Source/core/html/HTMLDialogElement.cpp - Issue 15159008: Node::lazyAttach shouldn't lie about being attached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLDialogElement.cpp

Issue 15159008: Node::lazyAttach shouldn't lie about being attached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Missing commit Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLDialogElement.cpp

diff --git a/Source/core/html/HTMLDialogElement.cpp b/Source/core/html/HTMLDialogElement.cpp

index 52718b342ab5b461b3d70542b19dc0b81c1d3652..298e4856d7c34a6f4a008422e7a8b7c78d2153d1 100644

--- a/Source/core/html/HTMLDialogElement.cpp

+++ b/Source/core/html/HTMLDialogElement.cpp

@@ -102,7 +102,7 @@ void HTMLDialogElement::positionAndReattach()

m_topIsValid = true;

// FIXME: It's inefficient to reattach here. We could do better by mutating style directly and forcing another layout.

- reattach();

+ lazyReattach();

}

void HTMLDialogElement::show()