Source/core/dom/shadow/ShadowRoot.cpp - Issue 15159008: Node::lazyAttach shouldn't lie about being attached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ShadowRoot.cpp

Issue 15159008: Node::lazyAttach shouldn't lie about being attached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Missing commit Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/Source/core/dom/shadow/ShadowRoot.cpp b/Source/core/dom/shadow/ShadowRoot.cpp

index 7c0aad967725d6a46399f432feb51b7eb775eff9..300a09441771ae84dcd0d2cc341935fb09960984 100644

--- a/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/Source/core/dom/shadow/ShadowRoot.cpp

@@ -142,6 +142,9 @@ void ShadowRoot::recalcStyle(StyleChange change)

StyleResolver* styleResolver = document()->styleResolver();

styleResolver->pushParentShadowRoot(this);

+ if (styleChangeType() == FullStyleChange)

eseidel 2013/05/16 22:48:25 I'm confused by this line. Can you give more cont

+ change = Force;

for (Node* child = firstChild(); child; child = child->nextSibling()) {

if (child->isElementNode())

toElement(child)->recalcStyle(change);