Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 15081003: Add flag to enable syncfs directory support to about:flags. (Closed)

Created:
6 years ago by Gaurav
Modified:
6 years ago
Reviewers:
kinuko
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add flag to enable syncfs directory support to about:flags. BUG=238877 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199257

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Gaurav
@kinuko There was some issue with the CL 15026008. They don't allow functions to initialize ...
6 years ago (2013-05-09 03:15:42 UTC) #1
Gaurav
https://codereview.chromium.org/15081003/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): https://codereview.chromium.org/15081003/diff/1/chrome/common/chrome_switches.cc#newcode1369 chrome/common/chrome_switches.cc:1369: const char kSyncEnableDirectoryOperation[] = "enable-sync-directory-operation"; This flag is duplicated ...
6 years ago (2013-05-09 03:17:07 UTC) #2
kinuko
On 2013/05/09 03:17:07, Gaurav wrote: > https://codereview.chromium.org/15081003/diff/1/chrome/common/chrome_switches.cc > File chrome/common/chrome_switches.cc (right): > > https://codereview.chromium.org/15081003/diff/1/chrome/common/chrome_switches.cc#newcode1369 > ...
6 years ago (2013-05-09 03:36:12 UTC) #3
kinuko
Is the previous patch reverted? lgtm https://codereview.chromium.org/15081003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (right): https://codereview.chromium.org/15081003/diff/1/chrome/browser/about_flags.cc#newcode1474 chrome/browser/about_flags.cc:1474: SINGLE_VALUE_TYPE(switches::kSyncEnableDirectoryOperation), Our initial ...
6 years ago (2013-05-09 03:36:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001
6 years ago (2013-05-09 07:49:36 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=50880
6 years ago (2013-05-09 08:06:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001
6 years ago (2013-05-09 08:55:40 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=50903
6 years ago (2013-05-09 09:12:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001
6 years ago (2013-05-09 17:03:59 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=51074
6 years ago (2013-05-09 17:15:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001
6 years ago (2013-05-09 17:47:23 UTC) #11
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=51140
6 years ago (2013-05-09 17:58:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001
6 years ago (2013-05-09 19:28:58 UTC) #13
commit-bot: I haz the power
6 years ago (2013-05-09 19:36:45 UTC) #14
Message was sent while issue was closed.
Change committed as 199257

Powered by Google App Engine
This is Rietveld 408576698