Add flag to enable syncfs directory support to about:flags.

Add flag to enable syncfs directory support to about:flags.

BUG=238877
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199257

[Gaurav, 2013-05-09 03:15:42]

@kinuko There was some issue with the CL 15026008. They don't allow functions to
initialize values in about_flags.cc it seems.

Can you take a look at this.

[Gaurav, 2013-05-09 03:17:07]

https://codereview.chromium.org/15081003/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/15081003/diff/1/chrome/common/chrome_switches...
chrome/common/chrome_switches.cc:1369: const char
kSyncEnableDirectoryOperation[] = "enable-sync-directory-operation";
This flag is duplicated in webkit/fileapi/syncable/syncable_file_system_util.cc

This is a quick fix, Not sure how to share flags between webkit/ and chrome/.
Will look into it later.

[kinuko, 2013-05-09 03:36:12]

On 2013/05/09 03:17:07, Gaurav wrote:
>
https://codereview.chromium.org/15081003/diff/1/chrome/common/chrome_switches.cc
> File chrome/common/chrome_switches.cc (right):
> 
>
https://codereview.chromium.org/15081003/diff/1/chrome/common/chrome_switches...
> chrome/common/chrome_switches.cc:1369: const char
> kSyncEnableDirectoryOperation[] = "enable-sync-directory-operation";
> This flag is duplicated in
webkit/fileapi/syncable/syncable_file_system_util.cc
> 
> This is a quick fix, Not sure how to share flags between webkit/ and chrome/.
> Will look into it later.

Per https://chromiumcodereview.appspot.com/15026008/#msg4 it seems it's ok.

[kinuko, 2013-05-09 03:36:44]

Is the previous patch reverted?  lgtm

https://codereview.chromium.org/15081003/diff/1/chrome/browser/about_flags.cc
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/15081003/diff/1/chrome/browser/about_flags.cc...
chrome/browser/about_flags.cc:1474:
SINGLE_VALUE_TYPE(switches::kSyncEnableDirectoryOperation),
Our initial flag naming was bad, but can you rename these to

enable-sync-... -> enable-syncfs-...
kSyncEnableDirectoryOperation -> kSyncFSEnableDirectory...

[commit-bot: I haz the power, 2013-05-09 07:49:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001

[commit-bot: I haz the power, 2013-05-09 08:06:35]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-09 08:55:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001

[commit-bot: I haz the power, 2013-05-09 09:12:45]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-09 17:03:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001

[commit-bot: I haz the power, 2013-05-09 17:15:59]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-09 17:47:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001

[commit-bot: I haz the power, 2013-05-09 17:58:55]

Retried try job too often on ios_dbg_simulator for step(s) googleurl_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-09 19:28:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grv@chromium.org/15081003/7001

[commit-bot: I haz the power, 2013-05-09 19:36:45]

Change committed as 199257