Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 15026008: Add enable-sync-directory-operation to about:flags (Closed)

Created:
7 years, 7 months ago by Gaurav
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add enable-sync-directory-operation to about:flags This adds a flag to about:flags to enable/disable syncfs directory support. BUG=238877 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199052

Patch Set 1 #

Patch Set 2 : fixed creating duplicate switch #

Total comments: 1

Patch Set 3 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/fileapi/syncable/syncable_file_system_util.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Gaurav
7 years, 7 months ago (2013-05-07 22:00:43 UTC) #1
Gaurav
7 years, 7 months ago (2013-05-07 22:17:22 UTC) #2
asargent_no_longer_on_chrome
Is there a bug associated with the change, so you can add a BUG=<number> line ...
7 years, 7 months ago (2013-05-07 22:37:23 UTC) #3
asargent_no_longer_on_chrome
Never mind about the "defining the string in both places" comment - that seems to ...
7 years, 7 months ago (2013-05-07 22:50:51 UTC) #4
Gaurav
7 years, 7 months ago (2013-05-07 22:58:58 UTC) #5
Gaurav
@michaeln files under webkit/fileapi/syncable/*
7 years, 7 months ago (2013-05-07 23:29:43 UTC) #6
asargent_no_longer_on_chrome
assuming the flag is renamed along the lines I suggested in my earlier comment, lgtm
7 years, 7 months ago (2013-05-07 23:35:42 UTC) #7
kinuko
webkit/ lgtm
7 years, 7 months ago (2013-05-07 23:43:18 UTC) #8
kinuko
https://codereview.chromium.org/15026008/diff/6001/webkit/fileapi/syncable/syncable_file_system_util.h File webkit/fileapi/syncable/syncable_file_system_util.h (right): https://codereview.chromium.org/15026008/diff/6001/webkit/fileapi/syncable/syncable_file_system_util.h#newcode22 webkit/fileapi/syncable/syncable_file_system_util.h:22: WEBKIT_STORAGE_EXPORT const char* GetFlagForDirectoryOperation(); Can we rename this method ...
7 years, 7 months ago (2013-05-07 23:44:28 UTC) #9
michaeln
looks like kinuko got there first (lgtm2)
7 years, 7 months ago (2013-05-07 23:58:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/15026008/16001
7 years, 7 months ago (2013-05-08 00:13:03 UTC) #11
kinuko
On 2013/05/08 00:13:03, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 7 months ago (2013-05-08 08:46:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/15026008/16001
7 years, 7 months ago (2013-05-08 17:01:08 UTC) #13
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 23:32:31 UTC) #14
Message was sent while issue was closed.
Change committed as 199052

Powered by Google App Engine
This is Rietveld 408576698