Issue 15075004: Update outdated comment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15075004: Update outdated comment. (Closed)

Created:
7 years, 7 months ago by Nico

Modified:
7 years, 7 months ago

Reviewers:
danakj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Update outdated comment. I made isfinite() c++11-compliant a while ago. BUG=none NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199067

Patch Set 1 #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	build/common.gypi	View		1 chunk	+4 lines, -7 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

Yes, I'm not removing the "typeof must go" part of the comment, that's still around ...

7 years, 7 months ago (2013-05-08 23:59:52 UTC) #2

danakj

LGTM https://codereview.chromium.org/15075004/diff/1/build/common.gypi File build/common.gypi (left): https://codereview.chromium.org/15075004/diff/1/build/common.gypi#oldcode3752 build/common.gypi:3752: # typeof() is also disabled in c++11 (but ...

7 years, 7 months ago (2013-05-09 00:02:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/15075004/1

7 years, 7 months ago (2013-05-09 00:06:14 UTC) #4

Message was sent while issue was closed.

Change committed as 199067

Expand Messages | Collapse Messages