Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Unified Diff: build/common.gypi

Issue 15075004: Update outdated comment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 2433392a2c1287d5fcad8be7820151add9448d8f..13bf66a401bc9ea9f592450652b6ab5ffa4130e9 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3746,16 +3746,13 @@
'-Wstring-conversion',
],
'OTHER_CPLUSPLUSFLAGS': [
- # gnu++11 instead of c++11 so that __ANSI_C__ doesn't get
- # defined. (Else e.g. finite() in base/float_util.h needs to
- # be isfinite() which doesn't exist on the android bots.)
- # typeof() is also disabled in c++11 (but we could use
danakj 2013/05/09 00:02:24 Oh, it mentioned typeof() here, but I see it's als
- # decltype() instead).
- # TODO(thakis): Use CLANG_CXX_LANGUAGE_STANDARD instead once all
- # bots use xcode 4 -- http://crbug.com/147515).
+ # gnu++11 instead of c++11 is needed because some code uses
+ # typeof() (a GNU extension).
# TODO(thakis): Eventually switch this to c++11 instead of
# gnu++11 (once typeof can be removed, which is blocked on c++11
# being available everywhere).
+ # TODO(thakis): Use CLANG_CXX_LANGUAGE_STANDARD instead once all
+ # bots use xcode 4 -- http://crbug.com/147515).
'$(inherited)', '-std=gnu++11',
],
}],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698