Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 15072003: Move StyleResolver and related classes to core/css/resolver (Closed)

Created:
7 years, 7 months ago by eae
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, pdr, Steve Block, caseq+blink_chromium.org, aandrey+blink_chromium.org, yurys+blink_chromium.org, dstockwell, gavinp+loader_chromium.org, jchaffraix+rendering, kenneth.christiansen, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, darktears, Nate Chapin, gavinp+prerender_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), Stephen Chennney, dglazkov1
Visibility:
Public.

Description

Move StyleResolver and related classes to core/css/resolver Move StyleResolver, ScopedStyleResolver, ViewportStyleResolver and support classes to a new core/css/resolver directory. Update include paths and build file as needed. R=eseidel@chromium.org BUG=239244 TESTED=No new tests, no change in functionality. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150003

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -6454 lines) Patch
M Source/WebKit/chromium/src/AutofillPopupMenuClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/css/BasicShapeFunctions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGradientValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSToStyleMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/DeprecatedStyleBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/DocumentRuleSets.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/ElementRuleCollector.h View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/css/FilterOperationResolver.h View 1 chunk +0 lines, -45 lines 0 comments Download
D Source/core/css/FilterOperationResolver.cpp View 1 chunk +0 lines, -521 lines 0 comments Download
M Source/core/css/FontLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaQueryMatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PageRuleCollector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/RuleSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SVGCSSStyleSelector.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/css/ScopedStyleResolver.h View 1 chunk +0 lines, -111 lines 0 comments Download
D Source/core/css/ScopedStyleResolver.cpp View 1 chunk +0 lines, -249 lines 0 comments Download
M Source/core/css/StyleMedia.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/css/StyleResolver.h View 1 chunk +0 lines, -534 lines 0 comments Download
D Source/core/css/StyleResolver.cpp View 1 1 chunk +0 lines, -3849 lines 0 comments Download
D Source/core/css/StyleResolverState.h View 1 chunk +0 lines, -170 lines 0 comments Download
D Source/core/css/StyleResolverState.cpp View 1 chunk +0 lines, -155 lines 0 comments Download
D Source/core/css/TransformBuilder.h View 1 chunk +0 lines, -53 lines 0 comments Download
D Source/core/css/TransformBuilder.cpp View 1 chunk +0 lines, -336 lines 0 comments Download
D Source/core/css/ViewportStyleResolver.h View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/core/css/ViewportStyleResolver.cpp View 1 chunk +0 lines, -167 lines 0 comments Download
M Source/core/css/WebKitCSSMatrix.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/css/resolver/FilterOperationResolver.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +5 lines, -5 lines 0 comments Download
A + Source/core/css/resolver/ScopedStyleResolver.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/css/resolver/StyleResolver.h View 1 2 chunks +13 lines, -13 lines 0 comments Download
A + Source/core/css/resolver/StyleResolver.cpp View 1 2 25 chunks +50 lines, -52 lines 0 comments Download
A Source/core/css/resolver/StyleResolverState.h View 1 chunk +169 lines, -0 lines 0 comments Download
A + Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/css/resolver/TransformBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/css/resolver/TransformBuilder.cpp View 3 chunks +20 lines, -21 lines 0 comments Download
A + Source/core/css/resolver/ViewportStyleResolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + Source/core/css/resolver/ViewportStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ShadowRoot.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyledElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ValidationMessage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/DateTimeEditElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/TextFieldDecorationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorInstrumentation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/LinkLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/animation/CSSPropertyAnimation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/animation/KeyframeAnimation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerBacking.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderSearchField.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderSlider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTextControlSingleLine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGClipPathElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElementRareData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGFontFaceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGradientElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGMaskElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
eae
7 years, 7 months ago (2013-05-09 00:27:59 UTC) #1
eseidel
lgtm So exciting!
7 years, 7 months ago (2013-05-09 03:57:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/15072003/9002
7 years, 7 months ago (2013-05-09 03:57:40 UTC) #3
eseidel
I'm looking forward to seeing this subsystem develop. I'm glad that you've broken it off ...
7 years, 7 months ago (2013-05-09 03:59:09 UTC) #4
commit-bot: I haz the power
Change committed as 150003
7 years, 7 months ago (2013-05-09 04:01:18 UTC) #5
eseidel
It's kinda disturbing how many files reach into this sub-system. I suspect we may want ...
7 years, 7 months ago (2013-05-09 04:03:18 UTC) #6
kenneth.r.christiansen
When moving files around please make sure to update WATCHERS
7 years, 7 months ago (2013-05-09 09:42:58 UTC) #7
eseidel
7 years, 7 months ago (2013-05-09 10:16:03 UTC) #8
Message was sent while issue was closed.
We should just make a presubmit which checks the validity of watchers paths.

Powered by Google App Engine
This is Rietveld 408576698