[InfoBar] Add InfoBarDelegate::GetIconID()

chrome/browser/infobars/infobar_delegate.h

Index: chrome/browser/infobars/infobar_delegate.h
diff --git a/chrome/browser/infobars/infobar_delegate.h b/chrome/browser/infobars/infobar_delegate.h
index 1fb7d632a9d9b1197125bcdeefbc3e1bd00099e3..66324e1934d1faf573f47417ffb3de0f304d1955 100644
--- a/chrome/browser/infobars/infobar_delegate.h
+++ b/chrome/browser/infobars/infobar_delegate.h
@@ -78,9 +78,13 @@ class InfoBarDelegate {
   // Called when the user clicks on the close button to dismiss the infobar.
   virtual void InfoBarDismissed();
 
+  // Return the resource ID of the icon to be shown for this InfoBar.  If the
+  // value is -1, no icon is shown.
+  virtual int GetIconID() const;
+
   // Return the icon to be shown for this InfoBar. If the returned Image is
   // NULL, no icon is shown.
-  virtual gfx::Image* GetIcon() const;
+  gfx::Image* GetIcon() const;

[tfarina, 2013/05/11 00:44:23]

if you kept the virtual, you could annotate this method as FINAL (see
base/compiler_specific.h), but if seems it doesn't need to be virtual anymore.

[gone, 2013/05/11 00:48:24]

Yeah, it turns out that all of the GetIcon() calls were doing the exact same
thing, but with different resource IDs.  I thought it would make more sense to
make that part of it virtual (in GetIconID()) and move the loading call here.

 
   // Returns the type of the infobar.  The type determines the appearance (such
   // as background color) of the infobar.