chrome/browser/ui/gtk/infobars/infobar_gtk.cc - Issue 15067008: [InfoBar] Add InfoBarDelegate::GetIconID()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/infobars/infobar_gtk.cc

Issue 15067008: [InfoBar] Add InfoBarDelegate::GetIconID() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit fixes redux Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/infobars/infobar_gtk.cc

diff --git a/chrome/browser/ui/gtk/infobars/infobar_gtk.cc b/chrome/browser/ui/gtk/infobars/infobar_gtk.cc

index 95d5b79588a67383e6b1489489ac37260a1c257e..a8b77bca709a57b3624d9b5597c2244840d0e648 100644

--- a/chrome/browser/ui/gtk/infobars/infobar_gtk.cc

+++ b/chrome/browser/ui/gtk/infobars/infobar_gtk.cc

@@ -91,9 +91,9 @@ void InfoBarGtk::InitWidgets() {

gtk_container_add(GTK_CONTAINER(bg_box_), padding);

// Add the icon on the left, if any.

- gfx::Image* icon = delegate()->GetIcon();

- if (icon) {

- GtkWidget* image = gtk_image_new_from_pixbuf(icon->ToGdkPixbuf());

+ gfx::Image icon = delegate()->GetIcon();

+ if (!icon.IsEmpty()) {

+ GtkWidget* image = gtk_image_new_from_pixbuf(icon.ToGdkPixbuf());

gtk_misc_set_alignment(GTK_MISC(image), 0.5, 0.5);