chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc - Issue 15067008: [InfoBar] Add InfoBarDelegate::GetIconID()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc

Issue 15067008: [InfoBar] Add InfoBarDelegate::GetIconID() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit fixes redux Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate.cc ('k') | chrome/browser/ui/extensions/app_metro_infobar_delegate_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc b/chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc

index 584a69735409133d385bc6576a08a5fb5ac2ed96..3bb78e14a5e0b6ec0b527d8f255a3d86c44f5cb4 100644

--- a/chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc

+++ b/chrome/browser/ui/content_settings/content_setting_changed_infobar_delegate_unittest.cc

@@ -13,7 +13,6 @@

#include "grit/theme_resources.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/base/l10n/l10n_util.h"

-#include "ui/base/resource/resource_bundle.h"

class ContentSettingChangedInfoBarDelegateTest :

public ChromeRenderViewHostTestHarness {

@@ -70,8 +69,7 @@ TEST_F(ContentSettingChangedInfoBarDelegateTest, InfoBar) {

message));

ConfirmInfoBarDelegate* c_infobar = infobar.get();

- EXPECT_EQ(&ResourceBundle::GetSharedInstance().GetNativeImageNamed(icon),

- c_infobar->GetIcon());

+ EXPECT_EQ(icon, c_infobar->GetIconID());

EXPECT_FALSE(c_infobar->GetMessageText().compare(

l10n_util::GetStringUTF16(message)));