Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Unified Diff: chrome/browser/infobars/simple_alert_infobar_delegate.h

Issue 15067008: [InfoBar] Add InfoBarDelegate::GetIconID() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit fixes Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/infobars/simple_alert_infobar_delegate.h
diff --git a/chrome/browser/infobars/simple_alert_infobar_delegate.h b/chrome/browser/infobars/simple_alert_infobar_delegate.h
index 73710b24fc19169327f4de2bf5c998dde278ecd6..b680ca82a54fadf53ba764692204342f7d6e8e4f 100644
--- a/chrome/browser/infobars/simple_alert_infobar_delegate.h
+++ b/chrome/browser/infobars/simple_alert_infobar_delegate.h
@@ -14,25 +14,25 @@ class SimpleAlertInfoBarDelegate : public ConfirmInfoBarDelegate {
public:
// Creates a simple alert delegate and adds it to |infobar_service|.
static void Create(InfoBarService* infobar_service,
- gfx::Image* icon, // May be NULL.
+ int icon_id, // May be |kNoIconID| if no icon is shown.
const string16& message,
bool auto_expire);
private:
SimpleAlertInfoBarDelegate(InfoBarService* infobar_service,
- gfx::Image* icon,
+ int icon_id,
const string16& message,
bool auto_expire);
virtual ~SimpleAlertInfoBarDelegate();
// ConfirmInfoBarDelegate:
- virtual gfx::Image* GetIcon() const OVERRIDE;
+ virtual int GetIconID() const OVERRIDE;
virtual string16 GetMessageText() const OVERRIDE;
virtual int GetButtons() const OVERRIDE;
virtual bool ShouldExpireInternal(
const content::LoadCommittedDetails& details) const OVERRIDE;
- gfx::Image* icon_;
+ const int icon_id_;
string16 message_;
bool auto_expire_; // Should it expire automatically on navigation?

Powered by Google App Engine
This is Rietveld 408576698