Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 15063003: Cut content/browser dependency on webkit_media (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Cut content/browser dependency on webkit_media BUG=237267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199384

Patch Set 1 #

Total comments: 1

Patch Set 2 : change if guards to GOOGLE_TV #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -40 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M media/base/media_switches.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.cc View 1 2 chunks +1 line, -1 line 0 comments Download
D webkit/media/media_switches.h View 1 chunk +0 lines, -18 lines 0 comments Download
D webkit/media/media_switches.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M webkit/media/webkit_media.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
This doesn't really change anything, but it makes the dependencies a bit easier to understand. ...
7 years, 7 months ago (2013-05-08 21:36:17 UTC) #1
Ami GONE FROM CHROMIUM
LGTM % could make a small improvement while you're at it. (the bot coverage for ...
7 years, 7 months ago (2013-05-08 21:43:13 UTC) #2
jamesr
Done. piman - could you OWNERS approve the content/browser/renderer_host change?
7 years, 7 months ago (2013-05-08 21:49:45 UTC) #3
piman
LGTM, if it's ok to change that flag from ANDROID to GOOGLE_TV (I don't know).
7 years, 7 months ago (2013-05-08 21:54:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15063003/8002
7 years, 7 months ago (2013-05-08 22:00:08 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, chrome_frame_net_tests, chrome_frame_tests, ...
7 years, 7 months ago (2013-05-09 04:03:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15063003/8002
7 years, 7 months ago (2013-05-10 04:53:51 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 05:22:07 UTC) #8
Message was sent while issue was closed.
Change committed as 199384

Powered by Google App Engine
This is Rietveld 408576698