Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3122)

Unified Diff: chrome/android/java/res/layout/update_menu_item.xml

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add code create 1dp transparent border in LocatoinBarPhone Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/update_menu_item.xml
diff --git a/chrome/android/java/res/layout/update_menu_item.xml b/chrome/android/java/res/layout/update_menu_item.xml
new file mode 100644
index 0000000000000000000000000000000000000000..cd169735ab3c980c537a0f545da2004bc8a6f598
--- /dev/null
+++ b/chrome/android/java/res/layout/update_menu_item.xml
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2015 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file.
+-->
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ style="@style/AppMenuItem"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:paddingTop="12dp"
+ android:paddingBottom="12dp"
+ android:orientation="horizontal" >
gone 2015/12/08 22:24:23 ---------------------------------------------- New
Theresa 2015/12/10 03:53:17 Done.
+ <LinearLayout
gone 2015/12/08 22:24:23 nit: indentation's wonky.
Theresa 2015/12/10 03:53:17 Done.
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_weight="1"
+ android:layout_gravity="start"
+ android:paddingEnd="9dp"
+ android:orientation="vertical" >
+ <TextView
+ android:id="@+id/menu_item_text"
+ android:textAppearance="?android:attr/textAppearanceLargePopupMenu"
+ android:textColor="#DC5554"
gone 2015/12/08 22:24:23 I think convention is to use lowercase instead of
Theresa 2015/12/10 03:53:17 Done.
+ android:layout_width="wrap_content"
+ android:layout_height="match_parent"/>
+ <TextView
+ android:id="@+id/menu_item_summary"
+ android:textAppearance="?android:attr/textAppearanceSmallPopupMenu"
+ android:textSize="12sp"
+ android:textColor="#646464"
+ android:layout_width="wrap_content"
+ android:layout_height="match_parent" />
+ </LinearLayout>
+ <view
gone 2015/12/08 22:24:23 Can't you just use <org.chromium.chrome.browser.ap
Theresa 2015/12/10 03:53:17 Done. Here and in menu_item.xml
+ class="org.chromium.chrome.browser.appmenu.AppMenuItemIcon"
+ android:id="@+id/menu_item_icon"
+ android:layout_weight="0"
+ android:layout_width="wrap_content"
+ android:layout_height="match_parent"
+ android:layout_gravity="end"
+ android:gravity="center_vertical" />
+</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698