chrome/android/java/res/layout/update_menu_item.xml - Issue 1505913003: Add update menu item and app menu icon badge

Side by Side Diff: chrome/android/java/res/layout/update_menu_item.xml

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add code create 1dp transparent border in LocatoinBarPhone Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout-sw600dp/toolbar.xml ('K') | « chrome/android/java/res/layout/toolbar.xml ('k') | chrome/android/java/res/menu/main_menu.xml » ('j') | chrome/android/java/res/values/dimens.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file.

	5 -->

	6 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 style="@style/AppMenuItem"

	8 android:layout_width="match_parent"

	9 android:layout_height="wrap_content"

	10 android:paddingTop="12dp"

	11 android:paddingBottom="12dp"

	12 android:orientation="horizontal" >
	gone 2015/12/08 22:24:23 ---------------------------------------------- New ---------------------------------------------- Newlines. <Woody looking awed> <Buzz, arm outstretched> Newlines everywhere. ---------------------------------------------- Seriously, though: newlines between children? Theresa 2015/12/10 03:53:17 Done. Show quoted text On 2015/12/08 22:24:23, dfalcantara wrote: > ---------------------------------------------- > Newlines. > > <Woody looking awed> <Buzz, arm outstretched> > > Newlines everywhere. > ---------------------------------------------- > > Seriously, though: newlines between children? > Done.
	13 <LinearLayout
	gone 2015/12/08 22:24:23 nit: indentation's wonky. nit: indentation's wonky. Theresa 2015/12/10 03:53:17 Done. Show quoted text On 2015/12/08 22:24:23, dfalcantara wrote: > nit: indentation's wonky. Done.
	14 android:layout_width="match_parent"

	15 android:layout_height="wrap_content"

	16 android:layout_weight="1"

	17 android:layout_gravity="start"

	18 android:paddingEnd="9dp"

	19 android:orientation="vertical" >

	20 <TextView

	21 android:id="@+id/menu_item_text"

	22 android:textAppearance="?android:attr/textAppearanceLargePopupMenu"

	23 android:textColor="#DC5554"
	gone 2015/12/08 22:24:23 I think convention is to use lowercase instead of I think convention is to use lowercase instead of caps for hex colors. Also, move the layout_* params right below the ID. Theresa 2015/12/10 03:53:17 Done. Show quoted text On 2015/12/08 22:24:23, dfalcantara wrote: > I think convention is to use lowercase instead of caps for hex colors. Also, > move the layout_* params right below the ID. Done.
	24 android:layout_width="wrap_content"

	25 android:layout_height="match_parent"/>

	26 <TextView

	27 android:id="@+id/menu_item_summary"

	28 android:textAppearance="?android:attr/textAppearanceSmallPopupMenu"

	29 android:textSize="12sp"

	30 android:textColor="#646464"

	31 android:layout_width="wrap_content"

	32 android:layout_height="match_parent" />

	33 </LinearLayout>

	34 <view
	gone 2015/12/08 22:24:23 Can't you just use <org.chromium.chrome.browser.ap Can't you just use <org.chromium.chrome.browser.appmenu.AppMenUItemIcon etc /> Theresa 2015/12/10 03:53:17 Done. Here and in menu_item.xml Show quoted text On 2015/12/08 22:24:23, dfalcantara wrote: > Can't you just use > <org.chromium.chrome.browser.appmenu.AppMenUItemIcon > etc > /> Done. Here and in menu_item.xml
	35 class="org.chromium.chrome.browser.appmenu.AppMenuItemIcon"

	36 android:id="@+id/menu_item_icon"

	37 android:layout_weight="0"

	38 android:layout_width="wrap_content"

	39 android:layout_height="match_parent"

	40 android:layout_gravity="end"

	41 android:gravity="center_vertical" />

	42 </LinearLayout>

OLD	NEW