Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 15039016: Fix stroked roundrects on Nexus 10 (Closed)

Created:
7 years, 7 months ago by jvanverth1
Modified:
7 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix stroked roundrects on Nexus 10. Due to floating point precision errors, using the formula b^2x^2 + a^2y^2 - a^2b^2 doesn't work on the Nexus 10 GPU. Changed to use x^2/a^2 + y^2/b^2 - 1. Addresses issue 1290. Committed: http://code.google.com/p/skia/source/detail?r=9110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M src/gpu/GrOvalRenderer.cpp View 3 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvanverth1
7 years, 7 months ago (2013-05-10 19:41:35 UTC) #1
bsalomon
On 2013/05/10 19:41:35, JimVV wrote: lgtm
7 years, 7 months ago (2013-05-10 19:53:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/15039016/1
7 years, 7 months ago (2013-05-13 14:26:51 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-13 14:41:06 UTC) #4
Message was sent while issue was closed.
Change committed as 9110

Powered by Google App Engine
This is Rietveld 408576698